The filename in the Content-Disposition header in filemanager_transfer() should be quoted. As it stands the filenames aren't interpreted correctly by the browser.

I'll submit a patch once you commit all the recent changes.

CommentFileSizeAuthor
#3 filemanager.module_49632_0.patch1.08 KBdrewish
#1 filemanager.module_49632.patch1.11 KBdrewish

Comments

drewish’s picture

drewish commented
StatusFileSize
new filemanager.module_49632.patch1.11 KB

Here's a patch that quotes the filename and also adds docs for the header parameter.

drewish’s picture

drewish commented
Status: Active » Needs review

For testing, a sample filename that fails without the patch is: "Democracy_Now!_(9am_on_Feb_16th,_2006).mp3"

drewish’s picture

drewish commented
Priority: Normal » Critical
StatusFileSize
new filemanager.module_49632_0.patch1.08 KB

The previous patch used filesize($filepath) which caused errors.

drewish’s picture

drewish commented
Status: Needs review » Fixed

Applied to HEAD.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)