Notice: Undefined index: reputation in /f5/phpwtf/public/sites/all/modules/mollom/mollom.module on line 335. when posting a comment.

CommentFileSizeAuthor
#1 496560.patch3.41 KBdave reid

Comments

dave reid’s picture

Status: Active » Needs review
StatusFileSize
new3.41 KB

Any other information about what you were doing? What kind of comment?

Looking through the Mollom specification it looks like the response doesn't have to contain that value, but it would probably be good to kind of clean up the logic in those structures. For instance:

Instead of
isset($GLOBALS['mollom_response']) && isset($GLOBALS['mollom_response']['session_id'])
we can just do:
isset($GLOBALS['mollom_response']['session_id'])

I also tried add the the 'merge default values' code in mollom_validate_analysis() but it led to one failure in the Fallback SimpleTests. Moving the code to mollom_set_data() worked perfectly.

dave reid’s picture

Assigned: Unassigned » dave reid
dave reid’s picture

Status: Needs review » Fixed

Commited to CVS.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.