I installed signup_restrict_by_role 6.x-1.1 but can't find any traces of this module. Where is it expected to interact with the Signup module 6.x-1.x-dev (2009-Jun-03)?

Comments

roball’s picture

Category: support » bug
Priority: Normal » Critical

The "README.txt" mentions, once the module has been enabled, "Checkboxes then become available in the signup section of signup enabled nodes.". However, no additional options here with Signup 6.x-1.x-dev (2009-Jun-03) :-(

roball’s picture

Title: Can't find what this module does » Module does not work at all
cletusalphonse’s picture

I don't see anything either

roball’s picture

I have now removed this useless module. The "Content Access" module now does the job and it does it excellent.

abaddon’s picture

this is a duplicate of http://drupal.org/node/275468 but that one is filled against 5.x
basically the module assumes your event enabled nodes are of type "event", it should actually check the signup enabled status of the node..
content access is NOT an alternative to this because it doesnt restrict the signup operation, just the view, and so it doesnt work with payed signups

gwtt’s picture

Issue tags: +database, +change

Yes, we had to fix this on our site. Here is what we did:

around line 14 we have:
if(strpos($form_id, 'node_form')) { // if ($form_id == 'event_node_form') { //changed because it obviously won't let us do what we want

around line 63:
//if ($node->type == 'event' && $node->signup) { // Why should this be restricted?
if ($node->signup) {

I pasted the comments so you could see the before and after.

You also need to run this on the database table (if you use a prefix, make sure to change the name in these queries).

alter table signup_restrict_by_role drop primary key;
alter table signup_restrict_by_role primary key (nid, rid);

Otherwise, you can't select multiple roles to allow. I found this out because I enhanced this module to allow requiring ALL the roles you check (well, I'm in the process of it).

I might create a separate issue or a patch for the table issue if I have some time...if anyone else wants to mooch my information here and do it, please do!

abaddon’s picture

Status: Active » Needs review
StatusFileSize
new1.39 KB

heres a patch for this, goes against 6.x-1.1 and fixes this, you might need to _uninstall_ the module and install it again for the primary key fix to take..or do it manually :-)

abaddon’s picture

Title: Module does not work at all » enable the module for other content types than the default "event" type

nicer title :-)

ebeyrent’s picture

Assigned: Unassigned » ebeyrent
ebeyrent’s picture

Version: 6.x-1.1 » 6.x-1.x-dev
Status: Needs review » Fixed

Please see commit #461612 - I have addressed a bunch of these issues, and I believe that it's working as intended now.

Please let me know if you have any other issues!

Status: Fixed » Closed (fixed)
Issue tags: -database, -change

Automatically closed -- issue fixed for 2 weeks with no activity.