Posted by rjbrown99 on June 19, 2009 at 11:49pm
| Project: | Invite |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Very easy feature request - increase the size of the e-mail subject box on the admin/user/invite/settings page. Right now it is limited to 30 characters, but using the token module with replacements you can very easily fill up the box. For example, including a single content profile field such as [profile-field_givenname-raw] already takes up 29 of the 30 available characters.
This would be done via editing invite_admin.inc and changing the #size in the following area of the code:
$form['email']['invite_subject'] = array(
'#type' => 'textfield',
'#title' => t('Subject'),
'#default_value' => variable_get('invite_subject', t('[inviter-raw] has sent you an invite!')),
'#size' => 30,
'#maxlength' => 64,
'#description' => t('Type the default subject of the invitation e-mail.') .' '. t('Use the syntax [token] if you want to insert a replacement pattern.'),
'#required' => TRUE,
);I would suggest changing it to something fairly lengthy, such as 90 characters to allow for token replacement space. Thank you.
Comments
#1
Actually it's probably #maxlength and #size, but I think you get the idea.
#2
+1
it's only maxlength, size is just the width of the box, which should fall back to the default imo
patch attached removes maxlength and size altogether
#3
#4
+1 to remove limit. As rfc 2821 and 2822 says - subject is unstructured field and have no limit but
rfc2822.txt 2.2.3. Long Header Fields
#5
I'd also like to vote for this patch to be committed, please
#8
If we increase the length of the admin field, we need to also increase the length in the front-end. Committed the attached patch. Thanks to the spammer for bringing this issue to my attention.
#9
Automatically closed -- issue fixed for 2 weeks with no activity.