Wrong dates when modifying public bookings
vmalmedy - June 20, 2009 - 14:14
| Project: | Public Bookings |
| Version: | 6.x-1.0-alpha3 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | tirsales |
| Status: | closed |
Description
Hi,
First, I really appreciate the work done on this module and the Bookings API and I'm eager for the node-version of the project...
The dates that appear when modifying public bookings (at /publicbookings/request/x/update) should be those that were introduced the first time, and a confirmation message should be sent to the user.
Vincent
#1
Thanks for the bug-report (if the wrong dates are displayed, this qualifies as a bug), I'll have a look after it.
#2
Could you test the attached patch?
Apologies for the delay.
#3
Committed this, as another long-standing bug is resolved with it (and I simply forgot to commit it previously). Feel free to reopen, if the above problem persists after either applying the patch or updating to the latest dev (as soon as it is released).
Regarding the email confirmation: With the latest dev of Bookings API a Rules-integration has been added. This would make it possible to contact the client of a booking whenever the booking is changed.
#4
#5
Apologies for the quadruple-post ... There was a severe bug in the way PASSPHRASES where generated and clients handled internally, which lead to the missing "update notifications" after a client changed his own booking.
The attached patch (already commited) should fix this (use together with the patch above)
#6
Thanks for the modification.
Nevertheless, you have deleted an opening brace at line 117 of publicbookings.public.inc (with the second patch).
With that corrected, it's working fine.
#7
#8
Thanks - and apologies for the mistake .. I really shouldnt diff under pressure.
Committed again.
The patch to fix the missing brace:
Index: publicbookings.public.inc
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/publicbookings/publicbookings.public.inc,v
retrieving revision 1.7.2.4
diff -r1.7.2.4 publicbookings.public.inc
117c117
<
---
> }
#9
And I shouldnt post when tired..
#10
Setting this to fixed - feel free to reopen if problems occur with this patch.
#11
Automatically closed -- issue fixed for 2 weeks with no activity.