Download & Extend
Issues

Missing margin-top/bottom on descriptions

Posted by hass on June 20, 2009 at 3:32pm
Project:Drupal core
Version:7.x-dev
Component:Garland theme
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:vertical tabs

Issue Summary

This CSS declaration seems missing for fieldset description's. The below makes sure that top spacing is correct if a fieldset description is shown on top of a vertical tab.

div.vertical-tabs .vertical-tabs-panes fieldset.vertical-tabs-pane div.description {
  margin-bottom: 1em;
  margin-top: 1em;
}
Login or register to post comments

Comments

#1

Posted by hass on October 3, 2009 at 10:42am
Status:active» needs review

Patch attached with removed DIV

AttachmentSizeStatusTest resultOperations
vertical_tabs_missing_description_margin-D6.patch655 bytesIgnored: Check issue status.NoneNone

#2

Posted by Dave Reid on November 27, 2009 at 4:39pm

Can you post screenshots before and after please?

#3

Posted by hass on November 28, 2009 at 12:17am

See attached

AttachmentSizeStatusTest resultOperations
vertitcal_tabs_without_fix.png15.98 KBIgnored: Check issue status.NoneNone
vertitcal_tabs_after_fix.png12.28 KBIgnored: Check issue status.NoneNone

#4

Posted by Dave Reid on November 28, 2009 at 11:28pm
Project:Vertical Tabs» Drupal core
Version:6.x-1.x-dev» 7.x-dev
Component:User interface» Garland theme

Just synced the D7 CSS with the backport module's CSS, so I think we need to bring this to core first then backport.

#5

Posted by cosmicdreams on March 15, 2010 at 3:49pm

Since the creation of this issue, I think the margins have been improved. I vote to mark this issue as fixed.

#6

Posted by cosmicdreams on March 15, 2010 at 3:57pm
Status:needs review» fixed

Double-checked the formatting, while this specific approach has not bee followed, margins are applied to fieldsets that make the formatting of this element better.

#7

Posted by System Message on March 29, 2010 at 4:00pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here