Right now there's no validation that prevents the same form key from being used multiple times.

- Pull out a textfield
- Pull out a second textfield
- Edit the second textfield and copy it's form key
- Edit the first textfield and give it the form key of the second textfield

The form will save properly, but upon reloading the page, the second textfield has been lost (since it was overwritten in the form by the first textfield).

Comments

quicksketch’s picture

quicksketch
he/him
commented

Part of this problem has been solved in #1404806: Use #type = 'machine_name' for key fields, which adds validation to the key field to ensure that the same key is not in use at the same place in the form. However it doesn't prevent a user from naming two fields the same in different locations of the form (such as in two different fieldsets), then dragging them into the same location (the same fieldset), which would cause a conflict. This is still a problem, though less likely to occur than before.

quicksketch’s picture

quicksketch
he/him
commented
Title: No prevention of duplicate key names » Prevent duplicate key names when re-ordering form

Clarifying the remaining problem.

torotil’s picture

torotil commented
Issue summary: View changes
Status: Active » Closed (won't fix)
Issue tags: +form_builder-6.x-wontfix

It seems that I'm the only active maintainer of form_builder at the moment and I'm not supporting 6.x-1.x since I don't use Drupal 6. Is this also reproducible in 7.x-1.x?