One of my goals for 2.x is to improve the styles to make it easier for folks to create new styles. I'm writing out my initial thoughts. If you have suggestions, please add a comment. Keep in mind, this is a meta discussion. Actual implementation and such needs to go in seperate issues.

Comments

icecreamyou’s picture

Using CSS sprites will probably make it harder to do drop-in replacements.

Also, integration with color.module would be nice.

michelle’s picture

Why would it be harder? You still have an "images" directory where you can swap out the icons.

As for color module, I'd love to but it's very complicated. I've had a couple of people offer to get it going but it never happened. That's one of those things that's likely only going to happen if someone submits a patch. As it is, it's pretty easy to recolor AF. There's a color key at the top of blue_lagoon. :) That's just regular colors, though, not graphics.

Michelle

icecreamyou’s picture

I was under the impression that if CSS sprites were used, in order to override one image in the sprite, the entire sprite would have to be overridden; and if the size of the image was different, the CSS would need to be changed. But I will admit that I don't know a lot about this, so I could be entirely misguided.

Yeah... I guessed as much. Eh well, as you say it's not a big deal, the Advanced Forum theming system is pretty good as-is... but then, you did ask for suggestions for improvements. :)

Good luck, and looking forward to 2.x (of course)!

michelle’s picture

Well, I don't know much about css sprites. I had to ask what the method phpbb uses was even called. :) But it seems to me that if you are going to replace the "plain" state of a button that you'd want to replace the "hover" state as well. I think it will be ok. We'll see once I implement it, probably later in the week. I have a few other things ahead of it in the mental queue. :)

Thanks,

Michelle

michelle’s picture

Status: Active » Closed (fixed)

Closing meta issue to reduce clutter.

Michelle