Patch for showing ellipsis correctly [#497876]

Attached is a patch to the tweet.module file. It does two things. The important one is that it fixes the adding of ellipses after truncating a title that is too long. I replaced the direct binary character (which wasn't working for me) with the UTF-8 sequence of characters that you want there instead. Seems to have done the trick.

The other change is a minor quibble. I changed the text that is displayed from "Post to Twitter" to "Tweet This".

Comment	File	Size	Author
	tweet.module.patch	1.32 KB	ev

Comments

Comment #1

icecreamyou commented 21 June 2009 at 21:07

Status:

Active

» Needs review

Hmm. You may be right that this is the approach to take; I know from experience that the HTML entity (…) doesn't work. I'll have to test it when I get a chance.

As far as changing the text, it's not going to change as you've suggested (this is by no means a clone of the Tweet This module for WordPress, despite the suggestion on the Tweet This website) and you can translate it if you'd like to change it. I will consider making it arbitrary, however.

Also, your patch format is wrong (not that that should stop you; any patch is better than no patch). Doesn't matter for me because I always patch by hand anyway, but you should look at http://drupal.org/patch before you write another one.

Comment #2

ev commented 21 June 2009 at 21:51

> I'll have to test it when I get a chance.

FYI, it worked fine for me with Firefox 3.0.11 on openSUSE 11.1.

> As far as changing the text, it's not going to change as you've suggested

Yep, that part of the patch was more in the realm of a suggestion. :-)
I like the more informal (and slightly shorter) phrase, but recognise others may not.

> I will consider making it arbitrary, however.

That would be good.

> Also, your patch format is wrong

No worries, thanks for the heads up. This is the first patch I've submitted and I just did a "diff -c" against the original file to generate it. I'll read that link before I do another. Thanks.