Recalculation of tax amounts / totals on edit

We don't even need a patch for this just change the code:

function _storminvoiceitem_beforesave(&$node) {
  if (!$node->tax) {
    $node->tax = $node->amount * $node->taxpercent * .01;
  }
  if (!$node->total) {
    $node->total = $node->amount + $node->tax;
  }
}

to

function _storminvoiceitem_beforesave(&$node) {
    $node->tax = $node->amount * $node->taxpercent * .01;
    $node->total = $node->amount + $node->tax;
}

I'm not sure why are those if's here, and i don't see the point. Invoice items and Invoice totals works nice without them.

As expected same thing is for expense:

function _stormexpense_beforesave(&$node) {
  $node->expensedate = _storm_date_to_gmtimestamp($node->expensedate);

  if (!$node->total) {
    $node->total = $node->amount + $node->tax;
  }
...

chage to

function _stormexpense_beforesave(&$node) {
  $node->expensedate = _storm_date_to_gmtimestamp($node->expensedate);

  $node->total = $node->amount + $node->tax;

...

Same thing with time tracking duration:

function _stormtimetracking_beforesave(&$node) {
  $timebegin = _storm_strtotime($node->timebegin);
  $timeend = _storm_strtotime($node->timeend);

  if (is_array($node->trackingdate)) {
    $node->trackingdate = _storm_datetime_to_gmtimestamp($node->trackingdate + $timebegin);
  }

  $node->timebegin = _timetostr($timebegin);
  $node->timeend = _timetostr($timeend);

  if (!$node->duration) {
    $node->duration = ($timeend['hour'] - $timebegin['hour'] + ($timeend['minute'] - $timebegin['minute']) / 60);
  }

...

Maybe I'm missing something?

I'm still experiencing this issue on 6.x-1.33

Please could you post some more details about the problem you´re experiencing, so we can see whether it is the same one and how the change above has helped / hindered.

Closed due to inactivity.