Fupload doesn't create correct filepath

One thing, I can say directly:

and the files in the tmp directory remains there.

Cron will delete these one later.

Token/Filefield paths might not work correctly in some cases, I still have to do some researches. Keep tracking it.

I am having similar issues on my test environment using XAMPP on Windows. I did a test upload of 20 or so images, and I'm not sure how much it's actually doing. It creates the nodes, and the image paths are there, but it adds the tmp directory to the path. It also isn't creating the images in the folder I specified for them, though the folder exists and drupal has no problems with the paths. I also noticed if I go back in and edit a node, remove the broken image and reupload, it works.

Here is the path it's generating:

http://localhost/algiershookah/sites/default/files/imagecache/test/C:\Web\Server\tmp/IMG_3990_0.JPG

Also doesn't work if I change the display of the field in CCK to use the full size image that is untouched by imagecache:

http://localhost/algiershookah/sites/default/files/C:/Web/Server/tmp/IMG_3990_0.JPG?1245886949

Another module seems to mess up the paths.

I am having similar problems. I am using Revisioning module. When I delete the revisions, the original files are deleted from sites/default/files/ folder. However, imagecache created version of images remain at sites/default/files//imagecache/storygallery . Also they remain at /tmp folder. I run cron, but they were not deleted. Record of deleted files are still at files table of the database with status 1.

It will take a while (a constant time) after the tmp images will be deleted.

However, imagecache created version of images remain at sites/default/files//imagecache/storygallery

This has nothing to do with fupload.

I have the same problem, the files will be uploaded to files dir instead of files/somedir/sometoken(or i created new content type called test and files were saved in test dir instead of test/[title-raw]) It drives me mad!!!

I can confirm the same behavior. Uploading images with image_fupload will keep files in the /tmp directory (as expected), but the stored paths seem to stay as the tmp files, and imagecache creates its images from there. The node finally stores images that are all like:
system/files/imagecache/photos_thumb/%252Ftmp/14_1_0.jpg
Tokens are properly processed when the filefield or regular image field rather than the image_fupload widget is selected.

Additionally, editing the node and resaving it actually has the expected behavior - the correct directories are created and the files are moved. The initial save, however, still doesn't work.

The actual token version might not work with FUpload.
If there's any time, I will check this. At least, this should be fixed in the complete rewrite which integrates better in CCK and, of course, in Drupal.

I am having similar issue. I created a photos sub-directory under files to put all the images in. When I upload images using Fupload it puts them in the 'files' directory not my 'files/photos' directory. I set the path in the content type image field under the 'Path settings" to 'photos'. I get the following error in my reports.

The directory sites/ourfatherschurch.org/files/photos is not writable, because it does not have the correct permissions set.

Directory permissions looks like this drwxrwxr-x.

What should the permission be?

Also, I love this module great work. It is a life saver when uploading many images for photo gallery.

It seems that you did not set the correct owner/group for the directory "photos". They have to be equal to "files" directory's owner/group and permissions.

Adding this :

if(!is_dir(file_directory_path() .'/'. $widget_file_path))
  	mkdir(file_directory_path() .'/'. $widget_file_path, 0777, true);

after this:

function _fupload_import_widget_files_directory($field) {
  $widget_file_path = $field['widget']['file_path'];
  if (module_exists('token')) {
    global $user;
    $widget_file_path = token_replace($widget_file_path, 'user', $user);
  }

so the whole function looks like this:

function _fupload_import_widget_files_directory($field) {
  $widget_file_path = $field['widget']['file_path'];
  if (module_exists('token')) {
    global $user;
    $widget_file_path = token_replace($widget_file_path, 'user', $user);
  }
  if(!is_dir(file_directory_path() .'/'. $widget_file_path))
  	mkdir(file_directory_path() .'/'. $widget_file_path, 0755, true);
  	
  return file_directory_path() .'/'. $widget_file_path;
}

in the file image_upload_imagefield.module around line 574 fixes the tmp and placement problems for me.

havnt tested it with the tokens yet but i imagine it will work for those as well.

cheers

mike

yup it works for tokens :D

Thank you, I will check this one.

Does this also work in conjunction with filefield path?

cheers, Ronald

This fixed it for me. Thank you ore. Great module grandcat.

I have tested it in conjunction with filepath module and it still doesn't work with it.

cheers, Ronald

The same problem (using with ImageField).

#13 code works for me (but not with Filefield path), thanks a lot.

Otherwise, the module is excellent (thanks for it), I hope that this bug will be fixed soon...

#13 is top! Thx!
But i need it for Filefild too, can you do anything?
lg

edit:
Sorry, Fupload and filepath upload works for me! very nice!

Hey all,

any update on Fupload + filefield path bug?

any workaround?

I'm sorry, don't have the time at the moment. Perhaps someone wants to provide a patch.
At least, I will fix it with the complete rewrite (FUpload will become smarter, Preview list will be replaced with Views + another module, ...).

I've tried the patch and it still doesn't work.

Also I have found that the filepath doesn't work with imagefield but does seem to work in conjunction with the image module

The code from #13 works well for me, here's a patch.

New patch uses file_check_directory() instead to check for the existence of the directory.

I have applied both these patches and is doesn't seem to make any difference, the filepath is still being ignored. Have I missed something?

@marcus178, are you using the Filefield path module? The patch isn't compatible with it.

Sorry I thought this related to Filepath

Committed to CVS Head. Thanks for all the help.

Thanks grandcat. For anyone looking to make this work with the Filefield Paths module, there is a separate issue for that: #409070: Image FUpload doensn't support file path tokens via Filefield Paths module.

this do not recursively create directory: only depth 1 directory creation. In drupal 7 file_prepare_directory does that.

I had a genial idea ;)

function _fupload_import_widget_files_directory($field) {
  $widget_file_path = $field['widget']['file_path'];
  if (module_exists('token')) {
    global $user;
    $widget_file_path = token_replace($widget_file_path, 'user', $user);
  }
  $dir = file_directory_path();
  $wfp_comp = explode('/',$widget_file_path);
  $error = false;
  while(!$error && $comp = array_shift($wfp_comp)) {
    $dir .="/$comp";
    $error = !file_check_directory($dir, TRUE);
  }
  if(!$error) return $dir;
  return file_directory_path();
  return file_directory_path() .'/'. $widget_file_path;
}

Thank you so much for this patch.. Out of curiosity, 2 years after it's release why hasn't this fix made it into the module yet?

the token [date-in-tz] that creates 3 directories (d/m/y) don't work.

if i use two tokens with a slash separator doesn't work too...

only works with only one token that creates only one directory.