This is also reported for 5.x, but not for 6.x, so I'll add it here.

Problem occurs for me when I delete a node that has a custom hook that uses taxonomy_del_term to delete the term that is linked to that node. Hence it calls hook_taxonomy but cause of a missing include I guess results in above error.

Regards,

HnLn

CommentFileSizeAuthor
#8 tac_498584_d5.patch9.76 KBxjm
#4 tac_498584.patch10.1 KBkeve
#2 taxonomy_access-498584-2.patch14.67 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented

Looks like there are several TAC module functions in in the admin.inc file that should be moved to the module file; in fact, I'd say everything from line 341 on. Does anyone have a reason that these functions should not be moved to the main module file?

xjm’s picture

xjm
she/her
Primary language English
commented
StatusFileSize
new taxonomy_access-498584-2.patch14.67 KB

Here's a patch that simply moves those functions over.

NB: patch is rolled at the directory level; use the -p option.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Needs review
keve’s picture

keve commented
StatusFileSize
new tac_498584.patch10.1 KB

I would roll lines from lines 428.
I would leave functions 'taxonomy_access_defaults_update' and 'taxonomy_access_grants_update' in admin section, because these functions update the settings (database values) from the admin UI. These are not used by other hooks, and are not intented for API functions like 'taxonomy_access_get_grants'.

XJM: Please mark it 'to be ported' if you agree.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Patch (to be ported)

Alright, looks good to me. :)

keve’s picture

keve commented
Status: Patch (to be ported) » Fixed

Patch is commited. Thanks for xjm.

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: Unassigned » xjm
Status: Fixed » Patch (to be ported)

We should backport this to D5. I will make a patch

Marked #338891: Line 260: Call to undefined function _taxonomy_access_get_nodes_for_term() as a duplicate.

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 6.x-1.0 » 5.x-2.x-dev
StatusFileSize
new tac_498584_d5.patch9.76 KB

Here is the patch for the 5.x branch (against 5.x-2.x-dev).

xjm’s picture

xjm
she/her
Primary language English
commented

Tested #8 with 5.x-2.x-dev; works fine.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Patch (to be ported) » Fixed

#8 committed to 5.x-2.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.