Jump to:
| Project: | UC Google Checkout |
| Version: | 5.x-1.5 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
I've been having problems in with UC Google Checkout. Google keeps sending me daily emails saying 'Attention required: order notification failing', and the Google checkout integration console says it's getting error 500 from my ubercart gcheckout server
(error 500 - http://checkout.google.com/support/sell/bin/answer.py?hl=en&answer=63436)
Drupal 5.18
Ubercart 5.x-1.7
UC Google checkout 5.x-1.5
People can still purchase stuff, and the first few order API communications between google and ubercart work successfully (i.e. an order is created with status 'in google checkout' and buyer details come through properly).
But it's been a few days of this and I think I've found the problem after some code digging. The 500 error (internal server error) must be caused by this (not really obvious) typo:
In uc_google_checkout.module, ver. 5.x-1.5, line 1457:function uc_google_checkout_notificiation_error($message = NULL) {
has a typo. It's being called at various places in the module, and should be:function uc_google_checkout_notification_error($message = NULL) {
I'm changing it now, going home and will see what Google errors I get in my inbox tomorrow.
Comments
#1
I don't think that will actually fix the order notification problem, but it should help you get to the real problem. That function writes the error messages to the watchdog so it's easy for you to review.
Committed the change to the function name.
#2
Well, I did not recieve any Google error messages this morning, but I also did not recieve any watchdog entries from uc_gcheckout or ubercart. What I did recieve is 2 new orders created with blank customer info and one of my previously purchased products in it. I'm not sure if this is related or caused by the google notification.
I wonder though, how does the google notification order number sent back correspond to the correct ubercart order number? (I haven't looked at the code yet).
#3
Apologies for not providing any further info sooner.
In the Drupal logs I sucessfully and consistently get the following notifications, presumably as I've been processing purchases from within the the Google Checkout web interface:
google 07/14/2009 - 09:28 Charging 27google 07/14/2009 - 09:28 Charged 27
google 07/14/2009 - 11:00 Delivered 27
But I did find this line in the server error logs:
[Mon Jul 13 12:53:39 2009] [error] [client xx.xx.xx.xx] PHP Fatal error: Call to undefined function uc_payment_enter() in /docroot/bookshop/sites/default/modules/uc_google_checkout/uc_google_checkout.module on line 1371And this is the code in uc_google_checkout.module:
uc_payment_enter($order_id, 'google_checkout', $charge['latest-charge-amount']['VALUE'], 0,'', t('Payment received by Google Checkout'));
Does this function need to be added?
#4
Weird. The uc_payment module should definitely be listed as a dependency of uc_google_checkout. Enable it, and the error shouldn't happen again. I don't understand how that slipped by, but I'll get that fixed.
#5
Automatically closed -- issue fixed for 2 weeks with no activity.