In Beta33 the Expiration Date is not working. Tracked it down to a query in the get_discounts_for_order() function. Patch attached.

CommentFileSizeAuthor
#6 uc_discounts_expiration.patch624 bytesmiguel_angel
#5 uc_discounts_expire.patch1.02 KBjrust
#1 uc_discounts_expiration.patch522 bytesjrust
import.txt22 bytesjrust

Comments

jrust’s picture

jrust commented
StatusFileSize
new uc_discounts_expiration.patch522 bytes

Wrong attachment, actual patch now attached ;)

melon’s picture

melon commented
Status: Needs review » Reviewed & tested by the community

I can confirm this, the fix above works great, thanks.

ryangroe’s picture

ryangroe commented

Applied and committed. Will be part of beta 34.

ezra-g’s picture

ezra-g commented
Status: Reviewed & tested by the community » Closed (fixed)

This was committed about 4 weeks ago. Thanks!

jrust’s picture

jrust commented
Version: 6.x-1.0-beta33 » 6.x-2.x-dev
Status: Closed (fixed) » Active
StatusFileSize
new uc_discounts_expire.patch1.02 KB

Bug re-appeared in the 2.x version. Attaching patch for that version.

miguel_angel’s picture

miguel_angel commented
StatusFileSize
new uc_discounts_expiration.patch624 bytes

Still the same bug in last commit. (2010.Aug.10)
Patch attached.

davidburns’s picture

davidburns
he/him
Primary language English
Location Philadelphia
commented

patch committed, http://drupal.org/cvs?commit=404848

thank you

davidburns’s picture

davidburns
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.