Creating a node with php input and editing it like below
let 'hello2' be displayed also on teasers on node listing pages.
(I had to separate minus from 'break' to let drupal.org post this)


hello
< !-- break -- >

<?php
print 'hello2';

?>
CommentFileSizeAuthor
#7 break_php_4.patch1.11 KBjohnalbin
#6 break_php_3.patch1.08 KBjohnalbin
#5 break_php_2.patch893 bytesjohnalbin
#4 break_php_1.patch893 bytesjohnalbin
#2 break_php_0.patch679 byteschx
#1 break_php.patch1.09 KBchx

Comments

chx’s picture

chx commented
Assigned: Unassigned » chx
Status: Active » Reviewed & tested by the community
StatusFileSize
new break_php.patch1.09 KB

[20:14] chx: what's our take with PHP node teasers?
[20:14] chx: if I have a PHP node which spits out 50K of text (just tested) then the teaser will be 50K long
[20:14] chx: not nice.
[20:14] UnConeD: chx: dries wanted to change it to support break
[20:14] UnConeD: and have it be your own fault if you make parse errors

chx’s picture

chx commented
StatusFileSize
new break_php_0.patch679 bytes

one hunk too more.

Steven’s picture

Steven commented
Status: Reviewed & tested by the community » Needs work

Actually, what we /should/ do for PHP code is to use the break tag if it's there, but do no automatic splitting otherwise (because that is surely to result in problems).

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Version: x.y.z » 5.x-dev
StatusFileSize
new break_php_1.patch893 bytes

Taking Steven's advice, we get... (for 4.7)

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
StatusFileSize
new break_php_2.patch893 bytes

And... (for 5.x-dev)

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Needs work » Needs review
StatusFileSize
new break_php_3.patch1.08 KB

New patch for 4.7.x-dev undoes (now unneeded) code added in http://drupal.org/node/80989

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
StatusFileSize
new break_php_4.patch1.11 KB

New patch for 5.x-dev undoes (now unneeded) code added in http://drupal.org/node/80989

Steven’s picture

Steven commented
Version: 5.x-dev » 4.7.x-dev
Status: Needs review » Reviewed & tested by the community

Committed to HEAD, works as advertised. Good job.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Reviewed & tested by the community » Fixed

applied

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)