Download & Extend
Issues

break, teaser, and php input

Posted by fax8 on February 17, 2006 at 7:38pm
Project:Drupal core
Version:4.7.x-dev
Component:node system
Category:bug report
Priority:normal
Assigned:chx
Status:closed (fixed)

Issue Summary

Creating a node with php input and editing it like below
let 'hello2' be displayed also on teasers on node listing pages.
(I had to separate minus from 'break' to let drupal.org post this)

hello
< !-- break -- >

<?php
print 'hello2';

?>
Login or register to post comments

Comments

#1

Posted by chx on March 27, 2006 at 6:19pm
Assigned to:Anonymous» chx
Status:active» reviewed & tested by the community

[20:14] chx: what's our take with PHP node teasers?
[20:14] chx: if I have a PHP node which spits out 50K of text (just tested) then the teaser will be 50K long
[20:14] chx: not nice.
[20:14] UnConeD: chx: dries wanted to change it to support break
[20:14] UnConeD: and have it be your own fault if you make parse errors

AttachmentSizeStatusTest resultOperations
break_php.patch1.09 KBIgnored: Check issue status.NoneNone

#2

Posted by chx on March 27, 2006 at 6:20pm

one hunk too more.

AttachmentSizeStatusTest resultOperations
break_php_0.patch679 bytesIgnored: Check issue status.NoneNone

#3

Posted by Steven on March 27, 2006 at 9:36pm
Status:reviewed & tested by the community» needs work

Actually, what we /should/ do for PHP code is to use the break tag if it's there, but do no automatic splitting otherwise (because that is surely to result in problems).

#4

Posted by JohnAlbin on December 4, 2006 at 12:04am
Version:x.y.z» 5.x-dev

Taking Steven's advice, we get... (for 4.7)

AttachmentSizeStatusTest resultOperations
break_php_1.patch893 bytesIgnored: Check issue status.NoneNone

#5

Posted by JohnAlbin on December 4, 2006 at 12:05am

And... (for 5.x-dev)

AttachmentSizeStatusTest resultOperations
break_php_2.patch893 bytesIgnored: Check issue status.NoneNone

#6

Posted by JohnAlbin on December 4, 2006 at 3:23am
Status:needs work» needs review

New patch for 4.7.x-dev undoes (now unneeded) code added in http://drupal.org/node/80989

AttachmentSizeStatusTest resultOperations
break_php_3.patch1.08 KBIgnored: Check issue status.NoneNone

#7

Posted by JohnAlbin on December 4, 2006 at 3:24am

New patch for 5.x-dev undoes (now unneeded) code added in http://drupal.org/node/80989

AttachmentSizeStatusTest resultOperations
break_php_4.patch1.11 KBIgnored: Check issue status.NoneNone

#8

Posted by Steven on December 12, 2006 at 10:05am
Version:5.x-dev» 4.7.x-dev
Status:needs review» reviewed & tested by the community

Committed to HEAD, works as advertised. Good job.

#9

Posted by killes@www.drop.org on December 12, 2006 at 12:49pm
Status:reviewed & tested by the community» fixed

applied

#10

Posted by Anonymous on December 26, 2006 at 1:00pm
Status:fixed» closed (fixed)