FUNCTION _send_submit()
- typo [if(!count($recipietns)) {]

FUNCTION _send_settings_form()
- shouldn't call to module_invoke($m,'send', 'settings', $m) reference $module, not $m? or am i missing something?
- think there needs to be a check on return value of module_invoke before calling array_merge, or a cast of the module_invoke return value in the array_merge call

i don't know how to make a patch yet, else i would just be providing it ....

thanks for this module, and for the 4.7 updates.

CommentFileSizeAuthor
#1 send.inc.2006-02-20.patch1.39 KBrmiotke

Comments

rmiotke’s picture

Status: Active » Needs review
StatusFileSize
new1.39 KB

Also, the #validate attribute on the 2 email address fields causes errors, and are redundant anyway since there are form-level checks of the fields. So i think they can be removed.

I've made my first stab at a patch, and have attached.

-r

allie micka’s picture

Status: Needs review » Fixed

Committed. thanks a lot!

Anonymous’s picture

Status: Fixed » Closed (fixed)