Allow users to select "Discard access logs older than: NEVER"

+1 vote for this as well. Additionally, a setting for archiving the data at an interval would be ideal. That way the table size could be kept down but the data would still exist, maybe downloaded as csv.

Chris

PS: I'm not sure if this should be 5.x-dev or 6.x-dev (probably 6.x I assume but it's set for 5.x for now.)

Sounds like a sensible suggestion. I'd also like to add a few more options of 26 and 52 weeks to extend it a little.

As for archiving, you could always do that directly from your database as and when required...

(moved to 6.x-dev as no new features will make it into 5.x now as far as I'm aware)

I've rolled a patch against current HEAD that:

• stops logs being discarded if access logging is disabled
• allows admin to enable/disable discarding of old access logs
• adds options for 26 weeks (6 months) and 1 year to the flush period

+1 to the idea of allowing never and longer periods of data collection, e.g. Dan's 26 and 52 week periods.

Patch looks good on inspection (I have not tested it).

I've also been thinking of other ways to make it more flexible, so people aren't limited to set periods, and could enter their own. I'm not entirely sure I like it, but one way I thought of doing this would be to have two fields: a text field for an integer and a dropdown selection box with 'seconds', 'minutes', 'hours', 'days', 'weeks', 'months' (? not fixed period) or 'years'.

Patch is working on my 5.0 sites and replaces nicely some code I added to 4.6. For those who want complete control over deletion, the deletion could be moved to a function that is called with the date for deletion. External modules could then request the deletion. The deletion could be added to an archive module that copies the log to an archive then requests the deletion. You would need a matching data request function so someone could request:

$date = 12345;
$old = statistics_old_data_get($date);
// Add old to archive. On success:
statistics_old_data_delete($date);

Sometimes there is also the need to completely reset, so that might be good to add an option for "Reset Logs" as well. I guess it could be done with the date changes that geodaniel suggested but say to delete at the current date/time.

Patch no longer applies due to the page split.

Moving up to Drupal 7.

Adding the novice tag. Anyone want to pick this up?

Why not do this for dblog too? http://drupal.org/node/560484

+1

I like the idea of never discarding it. Patch applies cleanly.

Works.

Makes sense to me. Committed to HEAD!

Would like to see this in D6 as well. Doesn't seem too hard, but I don't have any experience with the patch system (yet).

Here's a quick backport.

seems to work. option is available. however, i'm not sure how legitimate of a review this is, seeing as I'd have to set my clock forward on my system, to see if the logs ever get discarded, and thus watch the patch in action/time.

works, though, from what I can tell.

Committed, thanks.