Posted by Aron Novak on June 23, 2009 at 12:19pm
3 followers
| Project: | FeedAPI |
| Version: | 6.x-1.x-dev |
| Component: | Code feedapi_node |
| Category: | task |
| Priority: | critical |
| Assigned: | Aron Novak |
| Status: | closed (fixed) |
Issue Summary
With this patch it become possible to only execute tests for a specific part of FeedAPI, for example cron part, revision support, etc. There are multiple feedapi test classes with one parent class what contains the common parts.
| Attachment | Size |
|---|---|
| tests_restructure.patch | 50.63 KB |
Comments
#1
Some of the comment texts were fixed.
#2
Aron: could you describe what this patch does and why all tests are under feedapi_node?
#3
This patch explodes the different purpose test functions (like cron part, opml, revisions) into subclasses and introduces a parent class what contains the common functions.
why all tests are under feedapi_node?: because the majority of tests assumes that feedapi_node is available as a processor. In fact, after the tests are converted to simpletest2.x, it's no longer needed to sit under feedapi_node/ because SimpleTest 2.x can ensure nicely that feedapi_node module is enabled.
#4
"because the majority of tests assumes that feedapi_node is available as a processor"
I think we should move tests, that verify global FeedAPI behavior and / or contain global base classes into FeedAPI's root directory. As tests set up their environment themselves I think it's fine to assume that a particular submodule that is contained in the project is going to be available.
#5
#4 agree, I moved all the stuff under feeapi/tests what is not related to feed items and added some new classes, as feedapi_delete, feedapi_type, feedapi_upload.
#6
This is such a patch what I would like to see in FeedAPI 1.9.
#7
Committed. Extended w/ invalid URL acceptance in feedapi_error.test
#8
Automatically closed -- issue fixed for 2 weeks with no activity.