Posted by jchatard on June 23, 2009 at 2:44pm
Jump to:
| Project: | Featured Content Slider |
| Version: | 6.x-1.1 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Hi all,
First, thanks for this module, from what I've seen in the jungle of sliders, this one suits my needs. Except that I needed to override the output. I already did some hacking of the module for pasts project. Now I decided it would be better to give a patch to improve the module.
What does the patch?
- Auto rotate contents option is now working
- Glide animation duration option is working
- Direction option has been removed since I didn't find where this was implemented in the JS
- Removed unused (as far as I can tell) functions
- Respect Drupal naming conventions
- Removed unecessary permission
- Implemented administer content slider permission correctly
- Added hook_theme() and a theme_content_slider function so that we can override slider output at the theme level (not everyone wants a teaser, at least not me)
- Added t() calls where it was missing
- Removed t() calls where it was not necessary
- Moved inline JavaScript to Drupal scope with $(document).ready, so that we can put JS files at the bottom of page.tpl.php
- And other things I don't remember.
Not that using this patch, you will need to re-configure your Content slider settings.
I hope this helps, there is a lot to be done, mostly cleaning the JS file, which is not written the Drupal way and as there are many features that aren't implemented.
Jérémy
| Attachment | Size |
|---|---|
| content_slider.diff | 14.89 KB |
Comments
#1
Sorry if this a dumb question, but I'm having trouble applying the patch. Shuold I just put it in the module's folder and use "patch content_slider.diff" ?
Thanks.
#2
Will someone commit this patch to the latest code please so we can test it.
the module hasn't been updated since Jan 2010, do we need a new maintainer?
#3
Vako's idea is a good idea
#4
Thanks jchatard. I have patched the code. I am releasing the newer version of "featured content" in few hours from now.
#5
This is now fixed and released in the newer release.