SimpleTest hook_uninstall() does not delete the correct variables

boombatower - June 23, 2009 - 21:53
Project:Drupal
Version:7.x-dev
Component:simpletest.module
Category:bug report
Priority:normal
Assigned:boombatower
Status:closed
Description

In simpletest_uninstall() the removed variables are out of date and some of the newer ones are not removed at all.

#1

boombatower - June 23, 2009 - 21:55
Assigned to:Anonymous» boombatower
Status:active» needs review

Could not find a reference to simpletest_devel anywhere in Drupal 7.

simpletest_httpauth, simpletest_httpauth_username, simpletest_httpauth_pass are from the old httpauth setup.

simpletest_clear_results was not removed

AttachmentSizeStatusTest resultOperations
500270-simpletest-uninstall.patch811 bytesIdleFailed: Failed to install HEAD.View details

#2

System Message - June 24, 2009 - 01:05
Status:needs review» needs work

The last submitted patch failed testing.

#3

boombatower - June 24, 2009 - 02:13
Status:needs work» needs review

Test slave crapped.

#4

boombatower - June 24, 2009 - 23:46

Updated per: #500292: Provide a settings page for hidden SimpleTest variables.

AttachmentSizeStatusTest resultOperations
500270-simpletest-uninstall.patch881 bytesIdleFailed: Failed to install HEAD.View details

#5

boombatower - June 25, 2009 - 18:47

Other issue renamed variables.

AttachmentSizeStatusTest resultOperations
500270-simpletest-uninstall.patch839 bytesIdleFailed: Failed to apply patch.View details

#6

System Message - July 8, 2009 - 17:40
Status:needs review» needs work

The last submitted patch failed testing.

#7

boombatower - July 8, 2009 - 20:01
Status:needs work» reviewed & tested by the community

Extremely simple so I'll mark it for RTBC.

AttachmentSizeStatusTest resultOperations
500270-simpletest-uninstall.patch834 bytesIdlePassed: 11567 passes, 0 fails, 0 exceptionsView details

#8

Dries - July 9, 2009 - 10:21
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#9

System Message - July 23, 2009 - 10:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.