Download & Extend
Issues

SimpleTest hook_uninstall() does not delete the correct variables

Posted by boombatower on June 23, 2009 at 9:53pm
Project:Drupal core
Version:7.x-dev
Component:simpletest.module
Category:bug report
Priority:normal
Assigned:boombatower
Status:closed (fixed)

Issue Summary

In simpletest_uninstall() the removed variables are out of date and some of the newer ones are not removed at all.

Login or register to post comments

Comments

#1

Posted by boombatower on June 23, 2009 at 9:55pm
Assigned to:Anonymous» boombatower
Status:active» needs review

Could not find a reference to simpletest_devel anywhere in Drupal 7.

simpletest_httpauth, simpletest_httpauth_username, simpletest_httpauth_pass are from the old httpauth setup.

simpletest_clear_results was not removed

AttachmentSizeStatusTest resultOperations
500270-simpletest-uninstall.patch811 bytesIdleFailed: Failed to install HEAD.View details

#2

Posted by System Message on June 24, 2009 at 1:05am
Status:needs review» needs work

The last submitted patch failed testing.

#3

Posted by boombatower on June 24, 2009 at 2:13am
Status:needs work» needs review

Test slave crapped.

#4

Posted by boombatower on June 24, 2009 at 11:46pm

Updated per: #500292: Provide a settings page for hidden SimpleTest variables.

AttachmentSizeStatusTest resultOperations
500270-simpletest-uninstall.patch881 bytesIdleFailed: Failed to install HEAD.View details

#5

Posted by boombatower on June 25, 2009 at 6:47pm

Other issue renamed variables.

AttachmentSizeStatusTest resultOperations
500270-simpletest-uninstall.patch839 bytesIdleFailed: Failed to apply patch.View details

#6

Posted by System Message on July 8, 2009 at 5:40pm
Status:needs review» needs work

The last submitted patch failed testing.

#7

Posted by boombatower on July 8, 2009 at 8:01pm
Status:needs work» reviewed & tested by the community

Extremely simple so I'll mark it for RTBC.

AttachmentSizeStatusTest resultOperations
500270-simpletest-uninstall.patch834 bytesIdlePassed: 11567 passes, 0 fails, 0 exceptionsView details

#8

Posted by Dries on July 9, 2009 at 10:21am
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#9

Posted by System Message on July 23, 2009 at 10:30am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.