Branch HTML page not displaying

Darren Oh - June 23, 2009 - 22:17
Project:API
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

CVS commit 228146 introduced an error on branch HTML pages. On those pages, the second argument for api_page_file_router() is the branch short name, which doesn't match the switch statement. Patch to follow.

#1

Darren Oh - June 23, 2009 - 22:18
Status:active» needs review
AttachmentSize
api.module-500290-1.patch 650 bytes

#2

drumm - June 24, 2009 - 05:22

Is this the @mainpage page or others?

#3

drumm - June 24, 2009 - 05:54
Status:needs review» postponed (maintainer needs more info)

Th @mainpage issue was that I hadn't indexed it. What page can I use to reproduce this bug? The forms API reference is HTML and seems to be working.

#4

Darren Oh - June 24, 2009 - 14:03
Status:postponed (maintainer needs more info)» needs review

I think it depends on the number of directories in the path to the file. My forms API reference page is at contributions/docs/developer/topics/forms_api_reference.html.

P.S. I have confirmed that this is another MENU_MAX_PARTS issue.

#5

drumm - June 24, 2009 - 21:18

I think long term, the paths might have to change quite a bit: api/{project}/{file path with non-slash separator}[/(function|constant|global|object)/{name}][/{branch}]. This will fix #179062: handle duplicate function names too.

A stopgap fix would be preferred for now, but I think I need to be able to reproduce issue before proceeding.

#6

Darren Oh - June 25, 2009 - 01:49

You can reproduce it on api.drupal.org by setting MENU_MAX_PARTS to 5 instead of 7.

#7

drumm - July 7, 2009 - 05:00
Status:needs review» fixed

Committed a fix that changes all the file URLs to constant part length.

#8

System Message - July 21, 2009 - 05:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.