Provide a settings page for hidden SimpleTest variables
boombatower - June 23, 2009 - 22:19
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | simpletest.module |
| Category: | task |
| Priority: | normal |
| Assigned: | boombatower |
| Status: | closed |
Description
SimpleTest has two variables which can be quite handy, but both of which are not visible in any way other then by reading the code.
This patch creates a settings page for the two variables and is in preparation for the verbose mode setting to be provided by #500280: Provide a verbose mode for SimpleTest.
#1
#2
The last submitted patch failed testing.
#3
Test slave crapped.
#4
Very handy.
#5
The last submitted patch failed testing.
#6
#7
- If we're going to accept auth information we should have a username and password field IMO.
- The form descriptions are not really helpful. They don't tell me why authentication is useful, or when it should be configured. They don't tell me why I might want to clean after each test run. I think we need to make those settings more accessible for non SimpleTest experts -- or keep them hidden.
- Shouldn't this live under Site configuration?
#8
I purely matched SimpleTest variable that is a single field for username/password, I'll split it up on form.
Will add descriptions.
I wasn't sure about it living under site configuration. SimpleTest is a development tool and doesn't effect the overall site so it seemed odd to place it in site configuration. Most development tools have their own special settings and such and this seemed like a clean pattern to keep them out of site configuration.
Since I am starting something new I definitely want opinions...
I'll try and get new patch shortly.
#9
This should do the trick.
Please let the hook_uninstall() variable removal be cleaned up in separate issue: #500270: SimpleTest hook_uninstall() does not delete the correct variables
#10
#11
- Can you put the help text on one line for consistency?
- Where can people fine the [result_id]? The documentation is not telling me that.
- Can we reduce 'simpletest_httpauth_credentials_username' to 'simpletest_username'? Ditto for password.
Otherwise looks good.
#12
Summary of what this patch does:
simpletest_httpauth_credentialsintosimpletest_usernameandsimpletest_password.simpletest_clear_resultsvariable.#13
The last submitted patch failed testing.
#14
#15
OK, the latest changes look good. The location of the settings page is OK for now, but could be revisited as part of the new IA. Committed to CVS HEAD.
#16
Automatically closed -- issue fixed for 2 weeks with no activity.