That one looks pretty weird from the outside:

aegir@ceres:~/drupal-6.12/profiles$ drush dl single_user_blog
Project single_user_blog (6.x-1.x-dev) downloaded to                 [success]
/var/aegir/drupal-6.12profiles/.

I would have expected the install profile to be deployed in /var/aegir/drupal-6.12/profiles/single_user_blog. Instead it is in ~/drupal-6.12profiles/single_user_blog, pretty weird.

CommentFileSizeAuthor
#1 drush-incorrect_install_path_for_dl_profiles.patch652 bytesdman

Comments

dman’s picture

dman commented
Title: fails to download install profile in proper location » fails to download install profile in proper location. Incorrect path. Patch.
Status: Active » Needs review
StatusFileSize
new drush-incorrect_install_path_for_dl_profiles.patch652 bytes

Indeed.
I got the same.
Here's the simple fix.
Before:


/**
 * Determine a candidate destination directory for a particular site path and
 * return it if it exists, optionally attempting to create the directory.
 */
function pm_dl_destination_lookup($type, $drupal_root, $sitepath, $create = FALSE) {
  switch ($type) {
    case 'module':
      $destination = $sitepath . 'modules/';
      break;
    case 'theme':
      $destination = $sitepath . 'themes/';
      break;
    case 'theme engine':
      $destination = $sitepath . 'themes/engines/';
      break;
    case 'translation':
      $destination = $drupal_root . '/';
      break;
    case 'profile':
      $destination = $drupal_root . 'profiles/';
      break;
  }
  if ($create) {
    drush_log(dt('Attempting to create destination directory at !dir', array('!dir' => $destination)));
    @drush_op('mkdir', $destination, 0777, TRUE);
  }
  if (is_dir($destination)) {
    drush_log(dt('Using destination directory !dir', array('!dir' => $destination)));
    return $destination;
  }
  drush_log(dt('Could not find destination directory at !dir', array('!dir' => $destination)));
  return FALSE;
}

after:

    case 'profile':
      $destination = $drupal_root . '/profiles/';
      break;

drupal_root has no trailing slash;
Works for me (when running in the sites/sitename dir, and using CVS dl method)

anarcat’s picture

anarcat commented
Status: Needs review » Fixed

This was committed in http://drupal.org/cvs?commit=244222.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.