Drag and drop deletes URL path settings for terms
halstead - June 24, 2009 - 01:42
| Project: | Edit term |
| Version: | 6.x-1.2 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | halstead |
| Status: | closed |
Description
When reordering using the drag & drop feature on admin/content/taxonomy/1 custom url aliases are deleted for any term that been moved. (And saved.)
Commenting out "path_set_alias($termpath);" near line 360 fixes the problem.
It looks like the line above used to be needed in the past because the test was "if ($term->path) {" in the past but now that it has been changed to "if (isset($term->path)) {" it's not needed anymore.
#1
A proper patch. I tested with pathauto it seems to work fine.
#2
Could someone take a look at this patch? Thanks.
#3
I'm attaching a cleaner copy of this patch against DRUPAL-6--1 which seems to be more up to date then HEAD.
#4
Tested.
#5
Tested the patch and it works.
#6
#7
Yeah, that looks logical. Trusting that nothing too bad has come up in testing, I've committed to dev.
Thanks for that, and especially thanks for the testing!
Fixed in dev. Is it worth a point release? Lossage is bad, but maybe we can throw a feature in as well to make it worthwhile?
.dan.
#8
I've lost hundreds of term aliases a couple of times before I understood the nature of the bug, and had to reenter them manually, so I vote for a release.
#9
Fair enough!
[#589934]
I found another fix to roll in, so it's worth it. Looks like a few other issues/conflicts with aliases may also have been related to this.
#10
Automatically closed -- issue fixed for 2 weeks with no activity.