When uploading images or managing images and on the page where the title, caption, and gallery can be entered for each image, the Gallery listbox selector lists the galleries for the currently logged in user. When someone is managing the images in someone else's gallery, the gallery/image owner's galleries are not displayed.

Several users have edit permissions for the gallery and image nodes. The typical use case is an editor would go into someone else's gallery and manage the image information. If the gallery associated with an image needs to be changed, it should either be limited to the gallery/image owner's galleries or it should be a simple text entry box with lookup so that any existing gallery can be selected.

Comments

kmonty’s picture

kmonty
He/Him
Location Berlin, DE + SF, CA
commented
Assigned: Unassigned » kmonty

This is definitely an solid todo.

dddave’s picture

dddave commented
Priority: Critical » Normal

Bump

This is still not working. UID 1 can chose any gallery (good) but the criteria for other users seems to be pretty random. Neither the user's other galleries are all displayed nor is access limitation a factor here. I can send an image from my gallery (as normal user) to a password protected gallery created by another user. I am trying to make out a pattern...

justintime’s picture

justintime commented
Priority: Normal » Critical

I recall refactoring this for NG3, because I saw it was pretty broken. I'll see if I can backport it. Fairly critical bug I think.

justintime’s picture

justintime commented

Scratch the backport, the functions aren't even there anymore.

First off, node_gallery_access isn't consulted at any point, which is obviously a problem. However, I don't know exactly what permissions a person should need to move an image from one gallery to another:

1) Do they need edit perms on the gallery? I say yes.
2) Do they need upload/create image perms on the gallery? I don't think so, because we aren't uploading a new image.
3) Do they need edit permissions on the image node? I think so, but I'm not for sure. Much of the node_gallery_access module was written so that it doesn't matter what the permissions are on the individual image node, it only looks at the gallery.

Thoughts?

Tally’s picture

Tally commented

I edited the theme to hide the option for selecting the gallery for each image. I decided that my users did not need the ability to move images between galleries. They can just re-upload them if the image needs to be someplace else.

dddave’s picture

dddave commented
Priority: Normal » Critical

This feature is nice to have but not necessary. It could make the overall managing of images easier (moderating).

However:

2) What is the usecase of an user changing the gallery a pic belongs to without permissions to upload/create images? I am thinking that either it is the creator himself who is mixing his galleries or a moderator. In both cases the person should have permissions to do stuff....mmmh.

3) Again: What is a possible usecase where an user without such permissions would change the gallery for an image. Only the creator himself OR an admin would do such things.

My thoughts: Nice feature but to make it really usable it requires a special permissions set...I guess. Something like "Move images between own galleries" and "move galleries to all galleries".

Or make the first the default and only add the later and give us an option to hide this field.

Not really thought through but I am trying to sort my thoughts here. Maybe I'll come up with a better post later...

justintime’s picture

justintime commented
Version: 6.x-2.x-dev » 6.x-3.x-dev
Assigned: kmonty » Unassigned

I'm going to bump this up to NG3 and unassign it from kmonty since we don't know how to fix it yet. The only person that reported problems with it was @tally, and he found a workaround. That will give us time to contemplate it more.

My personal feeling is:
1) If the user is UID 1 or has 'administer node gallery', then we show all galleries in the dropdown.
2) If the current user can edit this gallery, populate the list with all the other galleries he can edit.

I'm certainly open to other ideas though, and we have time to discuss it.

justintime’s picture

justintime commented
Status: Active » Fixed

In the interest of moving along, I made an executive decision ;-)

If the logged in user has "administer nodes", "edit any [current-gallery-type] content" or "administer node gallery" permissions, then all galleries appear in the dropdown. Otherwise, only galleries owned by the owner of the current gallery will appear in the list.

I also enabled a checkbox (on by default) in the admin settings that allows you to disable changing the gallery from the manage images tab (thanks for the suggestion tally).

dddave’s picture

dddave commented

Sound sound. ;)

I am looking forward to play around with NG3 soon...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.