Thumbnails end up in links area on Acquia Marina theme
iva2k - June 24, 2009 - 04:57
| Project: | Upload Image |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
Description
It looks strange to have the thumbnails squished into the links area of the node. I'm using theme/acquia_marina.
#1
One more problem is the list bullets shown before each image.
I fixed both problems by changing the theme function and modifying the css. The principle is to add a div after the list, and make it "clear both" in css. That should work the same for all themes.
function theme_upload_image($list) {$output = '<div class="upload-image-images">';
$output .= theme('item_list', $list);
$output .= '<div class="upload-image-clear"></div></div>';
return $output;
}
In css:
div.upload-image-clear { clear: both; }#2
I rolled a patch (attached) that fixes the above styling problems. It also fixes couple of typos, one on settings page, as well as fixing #500480: Uploaded images screw up post counts on forums
#3
I have the same problem with Four Seasons theme on 5.19
Uploaded image thumbnails and drupal links are all mixed up!
I tried your CSS but it didn't have any effect - given my setup probably not so surprising...
I think I need the CSS equivalent of a carriage return - to push the links section down below the uploaded images. Any CSS geniuses out there?!?
#4
Doh...
When am I going to learn to read posts properly before posting!
#5
Your code in comment #1 worked for me iva2k -
But in the 5.x version of the module function theme_upload_image($list) { has an extra 's' at the end of image:
function theme_upload_images($list) {
Thanks for sharing this fix
G
#6
Great to hear that the fix works for you, plan9.
Hopefully maintainer will notice that the patch has been reviewed by community and commits the fix to CVS. Who knows how many themes are not showing upload_image properly.
BTW, I figured that creating image nodes just for the sake of showing image thumbnails is not such a great idea for the sites I maintain. [PLUG] Now, instead of upload_image I'm using the latest and greatest iTweak Upload v2.1 which does more than show image thumbnails. [/PLUG]