Write a test class for "Delete news items older than" setting. Should be done after #499680: Restructure tests to avoid wasted effort.

CommentFileSizeAuthor
#3 500794-3_expire_test.patch2.24 KBaron novak
#1 feedapi_expire.test.gz853 bytesaron novak

Comments

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Active » Needs work
StatusFileSize
new feedapi_expire.test.gz853 bytes

There is a test, but it's not successful yet.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Priority: Normal » Critical

This is such a patch what I would like to see in FeedAPI 1.9.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs work » Needs review
StatusFileSize
new 500794-3_expire_test.patch2.24 KB

Rerolled. Now all the tests are passed.

alex_b’s picture

alex_b commented
Status: Needs review » Needs work

Ideally, this test checks for X remaining items after deleting Y items that have expired. Would this be possible?

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented

it's not so straightforward to do that.
If we want to do that, i should only start it after #560882: Do not rely on active internet connection and 3rd party server at the tests
It would be too awkward to have a dynamic php feed what returns relative pubDates to time()

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs work » Fixed

I extended w/ such a case where not all items expired, but only 1. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.