Write simpletest for expiring items

Aron Novak - June 24, 2009 - 12:11
Project:FeedAPI
Version:6.x-1.x-dev
Component:Code feedapi (core module)
Category:task
Priority:critical
Assigned:Aron Novak
Status:closed
Description

Write a test class for "Delete news items older than" setting. Should be done after #499680: Restructure tests to avoid wasted effort.

#1

Aron Novak - July 6, 2009 - 14:43
Status:active» needs work

There is a test, but it's not successful yet.

AttachmentSize
feedapi_expire.test.gz 853 bytes

#2

Aron Novak - August 18, 2009 - 09:04
Priority:normal» critical

This is such a patch what I would like to see in FeedAPI 1.9.

#3

Aron Novak - August 21, 2009 - 08:28
Status:needs work» needs review

Rerolled. Now all the tests are passed.

AttachmentSize
500794-3_expire_test.patch 2.24 KB

#4

alex_b - September 17, 2009 - 21:37
Status:needs review» needs work

Ideally, this test checks for X remaining items after deleting Y items that have expired. Would this be possible?

#5

Aron Novak - September 18, 2009 - 08:38

it's not so straightforward to do that.
If we want to do that, i should only start it after #560882: Do not rely on active internet connection and 3rd party server at the tests
It would be too awkward to have a dynamic php feed what returns relative pubDates to time()

#6

Aron Novak - October 31, 2009 - 15:46
Status:needs work» fixed

I extended w/ such a case where not all items expired, but only 1. Committed.

#7

System Message - November 14, 2009 - 15:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.