links in body text are not encrypted
artatac - June 24, 2009 - 12:30
| Project: | Invisimail |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Works well with cck email field but links in body text are not encrypted. I have tried rearranging the filters - putting HTML filter above Encode email addresses no luck. I have even tried creating a new input filter that contains nothing but Encode email addresses and it does nothing.
I have tried with both Use javascript and no javascript - no difference. Obviously throughout I had Automatically create links from email addresses ticked
#1
Can you provide us with a sample of non-working text? This module does generally work, so there must be something off with either your text or settings.
#2
You will need to go to Site Configuration->Input Formats->List. Go to the Filters portion and check Encode email addresses.
#3
Oh I skipped a step. After you hit list, then you will need to click "Configure" for whichever Filter Type you are using.
#4
So turns out this is actually largely due to a problem in the way the regex parser was going through any fields set to be processed by the input filter. Was kinda sloppily done before, but with this patch, becomes...um, exact to the point of approaching litigiousness :) Point is, it ought to work now. It'll even respect (kinda) email addresses that have already been link-ified, encoding all the appropriate parts while leaving the rest alone.
The final regex is much more complicated than what we had before, but it fully conforms to the spec for email addresses, and is also broken up into commented pieces so that it's (hopefully) easier to understand the pieces and maintain in the future.
#5
After some testing I've committed the patch in #4. Hopefully that fixes stuff. :-)
#6
Automatically closed -- issue fixed for 2 weeks with no activity.