Opinion regarding misery integration
danielb - June 24, 2009 - 12:42
| Project: | Troll |
| Version: | 6.x-1.x-dev |
| Component: | Miscellaneous |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
I'm thinking of using the Troll module as a method by which people can blacklist/whitelist users for Misery. Misery would simply be an extra option dynamically added to punishment list in Troll, Misery would hook in and change the form and prepend a submit function to check if that added option was ticked. Then I can simply call troll_is_blacklisted() and unleash misery. Do you see any reason that wouldn't work?
#1
This wouldn't work would it, I've misunderstood what blacklist is for.
#2
#3
No, I think it would work. Why did you think it wouldn't?
Troll has two blacklists - an IP importer for the punishments and a DNS (realtime) blacklist for comment spam. troll_is_blacklisted() is the check for the non-realtime one at the start of troll_boot(), just before it performs the "punishments" for being a Troll.
I still haven't released a stable Troll package, so I granted you CVS on Troll if you want to mess with it, as long as you at least commit to both 6--1 and HEAD.
#4
There's also an IP ban in Troll, but that doesn't lead to punishments or have a nice function call to check it. It just redirects all banned IP's page requests to a blocked.html file.
#5
Sorry I got the impression blacklist is for blocking IPs supplied by an external service. Perhaps this will work out then!
#6
OK I've made a preliminary implementation. I have some testing to do, but it looks good so far! Thanks.
#7
Automatically closed -- issue fixed for 2 weeks with no activity.