Code in CVS is saved with the wrong line ending format [#501024]

Comment	File	Size	Author
#5	cck_redirection-501024-5.patch	796 bytes	guillaumeduveau
#4	cck_redirection-501024-4.patch	37.24 KB	guillaumeduveau
#1	cck_redirection-n501024.patch	7.31 KB	damienmckenna

Comment #1

damienmckenna

TN, USA

commented 24 June 2009 at 15:53

Status:

Active

» Needs review

Status	File	Size
new	cck_redirection-n501024.patch	7.31 KB

The attached file *should* convert all files back to normal line endings.

Log in or register to post comments

Comment #2

damienmckenna

TN, USA

commented 24 June 2009 at 15:55

Due to the weirdness of dealing with line endings vs creating patch files, I'm not 100% sure if the attached patch will work, but at the very least if each file is opened & re-saved as LF format in any text editor, it will resolve the problem.

Log in or register to post comments

Comment #3

damienmckenna

TN, USA

commented 24 June 2009 at 16:01

Priority:

Normal

» Critical

Updating the status as it is affecting our ability to do other work, e.g. #335829: No redirect if field is blank.

Log in or register to post comments

Comment #4

guillaumeduveau

Toulouse

commented 24 June 2009 at 20:47

Status	File	Size
new	cck_redirection-501024-4.patch	37.24 KB

Oh, now I understand why your latest patch was so long ! I tried this patch but cck_redirection.module still is in DOS format and with no EOL, so I ran dos2unix on the file and here's the 30KB patch...

Anyway good idea to submit this issue, let's deal with that first. There are a lot of coder finds too, do you think we should treat them in another issue ?

Log in or register to post comments

Comment #5

guillaumeduveau

Toulouse

commented 25 June 2009 at 16:44

Status	File	Size
new	cck_redirection-501024-5.patch	796 bytes

It's corrected in the lastest CVS and 6.x-1.2. The last thing is a remaining "End of line" problem in cck_redirection.info. Then we can start the real work !