Posted by DamienMcKenna on June 24, 2009 at 3:52pm
| Project: | CCK Redirection |
| Version: | 6.x-1.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Robin Monks |
| Status: | closed (fixed) |
Issue Summary
All of the files in CVS are saved with CRLF (Windows/DOS style) line endings whereas they should be saved with LF (UNIX/OSX style).
Comments
#1
The attached file *should* convert all files back to normal line endings.
#2
Due to the weirdness of dealing with line endings vs creating patch files, I'm not 100% sure if the attached patch will work, but at the very least if each file is opened & re-saved as LF format in any text editor, it will resolve the problem.
#3
Updating the status as it is affecting our ability to do other work, e.g. #335829: No redirect if field is blank.
#4
Oh, now I understand why your latest patch was so long ! I tried this patch but cck_redirection.module still is in DOS format and with no EOL, so I ran dos2unix on the file and here's the 30KB patch...
Anyway good idea to submit this issue, let's deal with that first. There are a lot of coder finds too, do you think we should treat them in another issue ?
#5
It's corrected in the lastest CVS and 6.x-1.2. The last thing is a remaining "End of line" problem in cck_redirection.info. Then we can start the real work !
#6
#7
In fact it's corrected in CVS HEAD but NOT in 6.x-1.2. My patch was for CVS HEAD so it still applies.
#8
Could someone please fix the v6.x-1.x branch? Thanks.
#9
6.x branch also fixed now.
#10
Automatically closed -- issue fixed for 2 weeks with no activity.