There's a couple of places where Domain Conf calls menu_get_menus() function which will result in errors when core Menu module is not enabled. Should we:
1. wrap all menu_get_menus() calls in an if statement with module_exists()
2. make core Menu a requirement to enable Domain Conf

I'd personally prefer the first option. Ken, what's your take on this? I'll gladly roll a patch once we settle on an approach to this.

CommentFileSizeAuthor
#2 501116-menu.patch7.49 KBagentrickard

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

First option is most proper. I had to do something similar with Locale module recently, so take a look there.

cf. lines 367 of domain_conf.module.

  // Change the default language.
  if (module_exists('locale')) {
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
StatusFileSize
new 501116-menu.patch7.49 KB

Fixed and committed to HEAD. I also re-arranged the Domain Conf form so that the optional elements (menu, language) are at the bottom, and split them out on the Batch action list.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.