Download & Extend

Users without set expiration permissions unable to save expirable nodes

Project:Node expire
Version:6.x-2.03
Component:Code
Category:bug report
Priority:critical
Assigned:vikramy
Status:closed (fixed)

Issue Summary

node_expire's form_alter validation always checks the value of node->expire, even when the authenticated user doesn't have permission to edit expiration dates.

Therefore when a user tries to save an expireable node type, they are greeted with the unfriendly "You have to specify a valid date." in reference to a #value field which doesn't even appear on the form.

Marking this critical since it effectively makes this module unusable for non-admins.

Comments

#1

That should say "nodeapi", not "form_alter"

#2

Here's a proposed patch. This is my first submitted patch, so go easy on me if the syntax isn't quite right (or if it doesn't work as intended!). The documentation was helpful but left a few questions unanswered.

AttachmentSize
node_expire-501346-2.patch 2.22 KB

#3

Status:active» needs review

How about this patch?
Edit: Will not work as intended.. Will work on it..

AttachmentSize
node_expire-501346.patch 611 bytes

#4

Status:needs review» needs work

#5

Status:needs work» needs review

The patch in this should solve this issue.

http://drupal.org/node/405608

#6

Assigned to:Anonymous» vikramy

Check out 6.x-2.x-dev. Report bugs.

#7

Status:needs review» fixed

Latest version must fix this. Reopen if not or file an issue if you find any new bug.

#8

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.