A number of sites I run use light text on a dark background. When panels sets the background to white, any text in that region is unreadable. In any instance where the background or the text colour changes, the other should also change, to maintain contrast on all themes.

See also #501600: Modules should not assume dark text on light background. I'm happy to supply a patch if it's gonna be accepted.

Here are all instances of background/foreground colour in panels:

sites/default/modules# find panels/ -name \*.css | xargs -I foo egrep -Hn "(#([0-9a-f]{3}){1,2}|color|red|white|black|rgb)" foo | egrep -v "(border|white-space)"                                                                                   
panels/css/panels_admin.css:136:  background-color: #FFFFDD !important;                                                                        
panels/css/panels_admin.css:141:  color: #E09010;                                                                                              
panels/css/panels.css:9:  color: #ccc;                                                                                                         
panels/css/panels.css:14:  background: white;                                                                                                  
panels/css/panels.css:20:  color: #000;                                                                                                        
panels/css/panels_dnd.css:15:  color: #3D9CD7;                                                                                                 
panels/css/panels_dnd.css:26:  background: #999;                                                                                               
panels/css/panels_dnd.css:47:  background: #ffffff;                                                                                            
panels/css/panels_dnd.css:65:  background: #ccc;                                                                                               
panels/css/panels_dnd.css:79:  color: #fff;                                                                                                    
panels/css/panels_dnd.css:80:  background-color: #3D9CD7;                                                                                      
panels/css/panels_dnd.css:85:  background-color: #888;                                                                                         
panels/css/panels_dnd.css:89:  background-color: #FFFFDD !important;                                                                           
panels/css/panels_dnd.css:91:  color: black !important;                                                                                        
panels/css/panels_dnd.css:95:  background-color: #B4B488 !important;                                                                           
panels/css/panels_dnd.css:101:  color: #E09010;                                                                                                
panels/css/panels_dnd.css:105:  color: #fff;                                                                                                   
panels/css/panels_dnd.css:106:  background-color: #2F78A5;                                                                                     
panels/css/panels_dnd.css:110:  background-color: #666;                                                                                        
panels/css/panels_dnd.css:114:  color: #fff;                                                                                                   
panels/css/panels_dnd.css:115:  background-color: red;                                                                                         
panels/css/panels_dnd.css:174:  background: #fff;                                                                                              
panels/css/panels_dnd.css:175:  color: #000;                                                                                                   
panels/css/panels_dnd.css:186:  color: white;                                                                                                  
panels/css/panels_dnd.css:192:  background-color: #2385c2;                                                                                     
panels/css/panels_dnd.css:197:  color: white;                                                                                                  
panels/css/panels_dnd.css:222:  color: white;                                                                                                  
panels/css/panels_dnd.css:253:  background: url(../images/arrow-active.png) center right no-repeat white;                                      
panels/css/panels_dnd.css:303:  color: #5b5b5b !important;                                                                                     
panels/docs/doxygen.css:27:     background-color: #e8eef2;                                                                                     
panels/docs/doxygen.css:36:     background-color: #e8eef2;                                                                                     
panels/docs/doxygen.css:44:       background-color: #e8eef2;                                                                                   
panels/docs/doxygen.css:65:       color: #1A419D;                                                                                              
panels/docs/doxygen.css:70:       color: #1A419D                                                                                               
panels/docs/doxygen.css:74:     background-color: #ddddff;                                                                                     
panels/docs/doxygen.css:79:     background-color: #6666cc;                                                                                     
panels/docs/doxygen.css:80:     color: #ffffff;                                                                                                
panels/docs/doxygen.css:85:     background-color: #6666cc;                                                                                     
panels/docs/doxygen.css:86:     color: #ffffff;                                                                                                
panels/docs/doxygen.css:90:     background-color: #6666cc;                                                                                     
panels/docs/doxygen.css:91:     color: #ffffff                                                                                                 
panels/docs/doxygen.css:103:    color: #0000FF                                                                                                 
panels/docs/doxygen.css:108:    color: #0000FF                                                                                                 
panels/docs/doxygen.css:112:    color: #0000FF                                                                                                 
panels/docs/doxygen.css:116:    color: #0000FF
panels/docs/doxygen.css:120:    background-color: #f2f2ff
panels/docs/doxygen.css:131:    background-color: #f5f5f5;
panels/docs/doxygen.css:142:    background-color: black;
panels/docs/doxygen.css:144:    color: #ffffff;
panels/docs/doxygen.css:161:    background: white;
panels/docs/doxygen.css:162:    color: black;
panels/docs/doxygen.css:167:    background-color: #e8eef2;
panels/docs/doxygen.css:180:    background-color: #e8eef2;
panels/docs/doxygen.css:193:    background-color: #f0f0f0;
panels/docs/doxygen.css:203:SPAN.keyword       { color: #008000 }
panels/docs/doxygen.css:204:SPAN.keywordtype   { color: #604020 }
panels/docs/doxygen.css:205:SPAN.keywordflow   { color: rgb(0, 119, 0); }
panels/docs/doxygen.css:206:SPAN.comment       { color: rgb(255, 128, 0); }
panels/docs/doxygen.css:207:SPAN.preprocessor  { color: #806020 }
panels/docs/doxygen.css:208:SPAN.stringliteral { color: rgb(221, 0, 0); }
panels/docs/doxygen.css:209:SPAN.charliteral   { color: #008080 }
panels/docs/doxygen.css:210:SPAN.vhdldigit     { color: #ff00ff }
panels/docs/doxygen.css:211:SPAN.vhdlchar      { color: #000000 }
panels/docs/doxygen.css:212:SPAN.vhdlkeyword   { color: #700070 }
panels/docs/doxygen.css:213:SPAN.vhdllogic     { color: #ff0000 }
panels/docs/doxygen.css:219:    background-color: #FAFAFA;
panels/docs/doxygen.css:230:    background-color: #FAFAFA;
panels/docs/doxygen.css:252:    background-color: #FAFAFA;
panels/docs/doxygen.css:270:    background-color: #FAFAFA;
panels/docs/doxygen.css:288:    background-color: #FAFAFA;
panels/docs/doxygen.css:306:    background-color: #FAFAFA;
panels/docs/doxygen.css:324:    color: #606060;
panels/docs/doxygen.css:325:    background-color: #FAFAFA;
panels/docs/doxygen.css:329:    color: #003399;
panels/docs/doxygen.css:338:    color: #000080;
panels/docs/doxygen.css:340:    background-color: #e8eef2;
panels/docs/doxygen.css:346:    color: #1A41A8;
panels/docs/doxygen.css:349:    color: #2A3798;
panels/docs/doxygen.css:357:    background: #e8eef2;
panels/docs/doxygen.css:369:    color: #606060;
panels/docs/doxygen.css:374:    background-color: #e8eef2;
panels/docs/doxygen.css:383:    background-color: #eef3f5;
panels/docs/doxygen.css:397:    background-color: #d5e1e8;
panels/docs/doxygen.css:412:    color: #602020;
panels/plugins/layouts/flexible/flexible-admin.css:22:  color: green;
panels/plugins/layouts/flexible/flexible-admin.css:31:  color: blue;
panels/plugins/layouts/flexible/flexible-admin.css:67:  background: url(grippie-vertical.png) center center no-repeat #eee;
panels/plugins/layouts/flexible/flexible-admin.css:79:  background: white;

Comments

merlinofchaos’s picture

merlinofchaos commented

A patch would indeed be accepted. I actually had skimmed this and didn't realize there wasn't a patch attached already or I would've said so a long time ago.

merlinofchaos’s picture

merlinofchaos commented
Status: Active » Postponed (maintainer needs more info)
naught101’s picture

naught101 commented

I'll write a patch as soon as I have time (probably when I next change a dark-background site with panels :) )

Merlin: would you prefer me to simply add in an appropriate background colour where necessary, or remove colours that aren't neccesary (like black text), or both? It might even be worth making two versions, one dark and one light, but that would probably be a pain to maintain considering the number of css files.

merlinofchaos’s picture

merlinofchaos commented
Status: Postponed (maintainer needs more info) » Active

I would add an appropriate background. At this point the entire UI needs to be pretty rigid in order to always work right.

naught101’s picture

naught101 commented
Assigned: Unassigned » naught101
merlinofchaos’s picture

merlinofchaos commented

Still interested in a patch.

kompressaur’s picture

kompressaur commented

subscribing

Letharion’s picture

Letharion commented
Status: Active » Closed (won't fix)

In an effort to clean up the many hundreds of open issues in the Panels queue, I'm going over all bug reports. If they haven't been updated in over a full year,
I'm going to assume that they no longar affect any one, and close it. I realise that some issues will be closed, that should remain open.
If this is the case, and you still have an interest in this issue, please just re-open it, setting the appropriate status, and providing exports and detailed instructions for reproducing the error.