in filter.module, no ids are attached to the table of input formats and roles. This table gets wide in a hurry, so for themes with constrained space it would be really helpful to be able to add CSS styles to adjust it.

Please accept my apology if this should be a 'feature request'.

Note that the role table in access control does have an id in the critical spot.

Comments

puregin’s picture

Version: 4.6.5 » x.y.z
Category: bug » feature

I agree that this would be a good thing to do.

However, I do think it is a feature request, and am marking as such, and correspondingly marking the version as CVS.

puregin’s picture

In 4.7, you should be able to get to the table via the enclosing form's id. However, this seems potentially awkward. Perhaps the themeing/usability experts have something to add :)

Djun

bmargulies’s picture

I've seem some forum posting asking for feedback from theme-authors. This issue is one of a few I submitted where core modules produce tables that overflow the available width.

A real long-term solution would be, IMHO, a more complex theme hook for table management. Using a style to shrink the font size as a way to try to force a table to fit is rather ugly. Rather, the module should be able to ask the theme to present all those columns, and the theme should be able to do things like rearrange the contents. Instead or 27 columns, use only 5 and put each 5 role's worth into a new block of rows. Or something. One way or the other, fancy-pants PIE CSS layouts are on a collision course with wide tables.

TDobes’s picture

AFAIK, all table creation is passed through the theme('table'). All you need to do is create a themename_table function in your theme which can modify how things are constructed. Is this the sort of table modification ability you were hoping for, bmargulies?

bmargulies’s picture

Let me read up on how the table theme hook works and see if I want to do an emily litella on this.

bmargulies’s picture

OK, I see, I could put one of these in template.php and then I could do the job. It looks like a really big job to get a good solution to constrained horizontal space, but it's a job.

I think that this suggestion of a div id is still not completely ridiculous.

I also wonder if there would be a good category to drop an issue suggesting some standard function that themes could hand off for skinny table construction.

LAsan’s picture

Version: x.y.z » 7.x-dev

Does this feature request applies to current version?

sun’s picture

Status: Active » Fixed

I think that we've already fixed this in HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.