Despite the fact that the biblio_hide_bibtex_braces setting is enabled.

Comments

dergachev’s picture

Status: Active » Needs review

This works for us.

Index: biblio/views/biblio_handler_citation.inc
===================================================================
--- biblio/views/biblio_handler_citation.inc    (revision 3877)
+++ biblio/views/biblio_handler_citation.inc    (working copy)
@@ -54,6 +54,11 @@

         $item->biblio_contributors = biblio_load_contributors($item->vid);
         $item->biblio_keywords = biblio_load_keywords($item->vid);
+        //EW_HACK
+        if (variable_get('biblio_hide_bibtex_braces', 0)) {
+          $item->title = biblio_remove_brace($item->title);
+        }
+        //END_OF_HACK
         $this->items[$vid] = $item;
       }
     }
rjerome’s picture

Status: Needs review » Fixed

Yep, that would work, I've added it to the code. The views support is still a moving target, so the same features are not guaranteed to exist yet.

Ron.
(http://drupal.org/cvs?commit=229746)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

danieleboyo’s picture

Version: 6.x-1.5 » 6.x-1.6
Status: Closed (fixed) » Needs review

Though the patch was committed, it seems like the functionality is not there. Does the 1.6 version of biblio not include this fix?

Thanks again for your time.

Daniele

rjerome’s picture

The code is there, you might want to check the "admin/settings/biblio" page in the "BibTex" section to make sure that the feature is turned on.

danieleboyo’s picture

The feature is turned on, but I believe it is a problem in the patch that you committed. Instead of getting the title from the item ($item->title), it was fetched from the node ($node->title). Hope that made sense. thanks again!

daniele

rjerome’s picture

Doh! Stupid mistake on my part, I'll fix that.

rjerome’s picture

Status: Needs review » Fixed

Ok, I've committed the fix.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

shaundychko’s picture

Status: Closed (fixed) » Needs work

This is now an issue with bibtex 6.x-1.15 and Views 6.x-2.14. The braces are removed correctly at /biblio, but not when displayed by Views.

shaundychko’s picture

Status: Needs work » Needs review
StatusFileSize
new544 bytes

The attached patch fixes it.

janepeng’s picture

Issue summary: View changes

Hi anyone can help?

The problem that the {Protected Braces} still shows up on views on my website. I am using bibtex 6.x-2.0-beta3 and Views 6.x-3.0 and have enabled the "Retain bibtex's {Protected} capitalization in the title string, but hide the braces on display".

Adding the code suggested in this post in biblio_handler_citation.inc by hand shuts down the website. It throws erros "Queries taking longer than 5 ms and queries executed more than once, are highlighted."

Thank you in advance!

Jane

shaundychko’s picture

Hi Jane,
I haven't had a chance to look at the code, but it looks like the function

biblio_remove_brace()

is the ticket to solving things. The code in the patch I made is for bibtex 6.x-1.x, not the 6.x-2.x branch. You'll have to look at the patch in #11 for inspiration and adapt it for your version.

janepeng’s picture

Hi ShaunDychko,

Thank you so much for your respond!

I have been debugging the module for the past couple of weeks and found out more about it.

All help welcome and most appreciated!

Jane

liam morland’s picture

Status: Needs review » Closed (outdated)

This version is no longer maintained. If this issue is still relevant to the Drupal 7 version, please re-open and provide details.