Closed (fixed)
Project:
Panels
Version:
6.x-3.0-beta2
Component:
Mini panels
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Jun 2009 at 04:52 UTC
Updated:
6 Sep 2009 at 23:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
sdboyer commentedLooks like flexible layout barfing on the way it pulls things together. An export of your panel would help a lot sorting this one out. Put it in an attachment please, don't paste it straight into the comment box :)
Comment #2
jackiepeters commentedI am also having this problem.
I get this .panels-flexible-region-1-videosvideos6151px.panels-flexible-region-1-videos6151%
And the source code looks like this:
iv class="panels-flexible-splitter flexible-splitter-for-panels-flexible-region-1-videos">
.panels-flexible-region-1-videos
videos
615
1
px
.panels-flexible-region-1-videos
615
1
%
Comment #3
jackiepeters commentedUPDATE:
Fix found
on line 345 in flexible.inc
change
if ($max == $position && $location == 'left') {
to
if (($renderer->admin) && ($max == $position && $location == 'left')) {
The problem is that that stuff is SUPPOSED to show up in admin section, but not on the actual page.
UPDATE:
It breaks the admin side, I'll go through commenting out code till I find the specific piece causing it and will update again later
OK, I found a fix but I'm not sure if it will break anything else
In plugins->layouts->flexible->flexible.inc I commented out most of the function that makes that splitter row, just leaving the open and close parent div
Comment #4
servantleader commentedI have the same bug
I see:
.panels-flexible-column-1-13134031px.panels-flexible-column-1-134031%
I am not sure if I want to just comment out code, but it looks like we are close to a fix.
This should be considered critical because it breaks all the output on several people's sites.
Comment #5
mathieu commentedI had a very quick look at this - I'm no panels specialist. Any change in function panels_flexible_render_splitter() seems to break the "layout designer" in the admin section. I've got the feeling that maybe this function is called in a place (or a way) it shouldn't.
That's all I can do in 15 minutes, but I thought it was better than just adding another "subscribe" message.
Comment #6
omar commentedI have experienced this too. Here is export of the minipanel that uses flexible layout along with the specific strings generated by it.
The leftmost regions shows ".panels-flexible-region-10-about_tniabout_tni4841px.panels-flexible-region-10-about_tni4841%"
The center regions shows ".panels-flexible-region-10-newsletternewsletter1001px.panels-flexible-region-10-newsletter1001%"
The right regions shows ".panels-flexible-region-10-donatedonate2131px.panels-flexible-region-10-donate2131%
I hope that this is helpful in some way.
Omar
Comment #7
omar commentedI just upgraded to beta4 and the problem seems to persist.
In case it makes a difference, note that I didn't try to recreate the panel from scratch.
Omar
Comment #8
merlinofchaos commentedjackiepeters: I tried out your solution and I couldn't see where it broke the admin side. So I have committed that.
Comment #10
xdecibelx commentedThanks for the quick fix, I had the same issue!