Posted by iva2k on June 26, 2009 at 6:06am
| Project: | Node Comments |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
When trying to change forum content type to Comments>read/write, Node type for comments: Comment, the setting is reported as applied ("The content type Forum topic has been updated."), however, Default comment setting: remains disabled, and it does not stick to either read or read/write.
As soon as I change Node type for comments: -- Drupal comments --, Default comment setting sticks to Read/Write.
I've installed from CVS (as of 6/25/2009, 10:40PM PDT):
- nodecomment DRUPAL-6--2
- advanced_forum DRUPAL-6--2
- views HEAD
- ctools HEAD
Drupal core is 6.12
Comments
#1
I was able to track that problem down. It turns out that in a few places nodecomment.module checks for 'comment_type' and 'comment_view' instead of 'node_comment_type' and 'node_comment_view'. Couple of edits fixed the above problem.
Please review the attached patch for committing to 2.x-dev
I'm raising the priority to critical, since the problem becomes a serious usability issue. When site admin enables comments by default (read/write), it is intended that most of that content type will have comments enabled. However, when site admin uses nodecomment, this is completely broken by the bug which forces default setting for comments to "Disabled". When site users post new content of that type, it ends up without comments, unless they know to uncollapse "comments" and enable them back (which is only explored by very few advanced users). It is most apparent in Forums.
#2
Originally encountered in advanced forum, but this bug is present in any content types. More appropriate title.
#3
For what it's worth, I've applied this and it does seem to fix the problem.
#4
I believe this patch will fail to apply after the most recent NodeComments dev update (pretty sure I was patching correctly), but I applied it manually and it worked fine.
#5
#6
The patch addresses apparent goof in the code. I am willing to reroll the patch to latest -dev, but only if maintainer voices if he is willing to take a look at it. It is fruitless to chase ongoing development otherwise.
#7
Sorry guys, I've been swamped and I don't know how I didn't notice this bug. I don' thave notifications on for this queue and I forgot to check the 2.x side recently (I'm not touching 1.x at all).
Rerolled manually and committed.
#8
Automatically closed -- issue fixed for 2 weeks with no activity.