On upgrade the size settings should be prefilled with good defaults

Hi, right i think i've sorted this one.

the problem was with the image size options form [flexinode_field_image_config function], the options were missing a closing ']', so the fields were not being read correctly thus causing the error.
i just added the the missing ']' to each option and it seems to have fixed the errors.

replace your flexinode_field_image_config function [line 137 i think] with this:

function flexinode_field_image_config($field) {

if (!isset($field->options)) {
$field->options = array(
1 => '800x600',
2 => '512x384',
3 => '100x100',
4 => 100,
);
}

$form['tester'] = array(
'#type' => 'fieldset',
'#title' => t('Options'),
'#description' => t('Options for the image upload.'),
);
$form['tester'][] = array('options][1]' => array(
'#type' => 'textfield',
'#title' => t('Maximum picture dimensions'),
'#default_value' => $field->options[1],
'#description' => t('Maximum dimensions for pictures. Format: WidthxHeight'),
));
$form['tester'][] = array('options][2]' => array(
'#type' => 'textfield',
'#title' => t('Preview dimensions'),
'#default_value' => $field->options[2],
'#description' => t('Dimensions for auto-created preview (scale will be preserved). Format: WidthxHeight'),
));
$form['tester'][] = array('options][3]' => array(
'#type' => 'textfield',
'#title' => t('Thumbnail dimensions'),
'#default_value' => $field->options[3],
'#description' => t('Dimensions for auto-created thumbnail (scale will be preserved). Format: WidthxHeight'),
));
$form['tester'][] = array('options][4]' => array(
'#type' => 'textfield',
'#title' => t('Maximum picture size'),
'#default_value' => $field->options[4],
'#description' => t('Maximum picture file size, in kB.'),
));

return $form;
}

i don't know how to make a patch so if someone else out there wants to do that i'm sure lots of people would appreciate it.

thanks

Tom

please provide a real patch. http://Drupal.org/diffandpatch

I tried this patch, but still have the same errors...

Can we get an update on this? Does this work? Will it be committed? I've tried this again, but I am still getting the same errors when updating a flexinode with an image field (ignore the stuff about general versus field comments, I think this is related directly to the field_image.inc file, as the errors occur with flexinodes whether or not they have inline images-- the common denominator is the image field for flexinode).

The above change doesn't make anything worse, so should the file be patched with this, even though it doesn't take care of these errors:

imagegif(): Unable to open 'files/AlpineSeal_th.gif' for writing in /gov/mysite/WWW/includes/image.inc on line 300.

imagedestroy(): supplied argument is not a valid Image resource in /gov/mysite/WWW/includes/image.inc on line 229.

imagegif(): supplied argument is not a valid Image resource in /gov/mysite/WWW/includes/image.inc on line 300.

imagecopyresampled(): supplied argument is not a valid Image resource in /gov/mysite/WWW/includes/image.inc on line 226.

imagecreatetruecolor(): Invalid image dimensions in /gov/mysite/WWW/includes/image.inc on line 225.

Thanks for any help with this. I can create a patch, if anyone can post code that will fix these errors. Thanks.

Right now my file permissions are definitely open to that...

At the top of field_image.inc there is this comment:

This seems to be the cause of these errors.

flexinode_field_image_insert() calls flexinode_field_image_make_smaller() and this calls image_scale().

image_scale() is in /includes/image.inc where all the errors are seen.

can you be more specific?

I can't find anything specific to what you're saying:
"go to administer / content, content types and edit the image fields and set proper options."

(what "image fields" are you refering to? where?)

closest i've found to "Maximum picture dimensions", "Preview dimensions", "Thumbnail dimensions" and "Maximum picture size".

is

Home » administer » settings » image

shows:
Label Width Height
thumbnail 100 100
preview 640 640

and there are 3 empty rows below that...

http://drupal.org/node/43436 was marked duplicate of this issue

with al the fixes i think the priority can be brought down.