Download & Extend
Office Hours » Issues

Choosing midnight

Posted by mnapier on June 26, 2009 at 3:34pm
Project:Office Hours
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I'm working with the 12hrs time format and attempting to set a closing time as 12:00 am (midnight). When choosing 12 00 AM it NULLS out the day in the database. Anyone else running into this? have a fix?
I'll see if I can come up with a patch in the meantime.

Login or register to post comments

Comments

#1

Posted by mnapier on June 26, 2009 at 3:38pm
Title:Choosing midnight as time» noon problems too

Just noticed that selecting 12 00 PM gets switched to 12 00 AM on the next edit and then the previously defined bug ends up wiping out that day.

#2

Posted by mnapier on June 26, 2009 at 4:19pm
Title:noon problems too» Choosing midnight

Here's a patch to fix the 12 00 PM from switching to 12 00 AM when editing.

AttachmentSize
office_hours.noon_.patch 544 bytes

#3

Posted by mnapier on June 26, 2009 at 9:44pm

Midnight fix patch. makes it so 0 (midnight) can be stored in the database.

AttachmentSize
office_hours_midnight.patch 511 bytes

#4

Posted by Ozeuss on June 27, 2009 at 10:42am

Thanks!
commiting both...

#5

Posted by mnapier on July 1, 2009 at 6:19pm

something else must have not jived well with these patches on the latest release, there still seems to be some issues with 12 am.

#6

Posted by mikl on August 29, 2009 at 7:52am
Status:active» postponed (maintainer needs more info)

Original patch was committed here: http://drupal.org/cvs?commit=230630

If you are still having issues, please try to describe them so we can fix them :)

#7

Posted by dogmatix on September 16, 2009 at 3:40pm

I'm using the latest version available on the module's page, and if I set or change an Until time to 12:00 AM, it wipes the whole Office Hours fieldset.

I just checked, and it also wipes if I set the From time to midnight.

I'm using 12 hour settings, granularity is Hours.

btw, it seems to ignore granularity, since the drop-down menu for the minutes shows all minutes from 00 - 59. Unless I'm misunderstanding what the granularity is meant for.

Unfortunately, I can't use this module with this bug. Our building closes at midnight. I really like it though and will keep an eye out for updates.

#8

Posted by mikl on September 17, 2009 at 7:02am

#7: Just to be sure, are you using the Drupal 6 dev release or something else?

#9

Posted by dogmatix on September 17, 2009 at 3:49pm

Sorry I guess I didn't mention the version. Yes, I'm using the Drupal 6 dev release. I was going to apply the patch mentioned above, but I noticed that the code from the patch was already in the version of Office Hours that I was using.

#10

Posted by vett09 on January 13, 2010 at 6:15pm

Having the same issue with 6 dev release. In the 12 hour format, if I choose 3pm - 12am, it does not save correctly. Those set of hours will just blank out.

#11

Posted by Ozeuss on January 23, 2010 at 7:33pm

fix committed

#12

Posted by johnv on October 17, 2011 at 3:09pm
Status:postponed (maintainer needs more info)» fixed

Closing issue, since :

fix committed

#13

Posted by System Message on October 31, 2011 at 3:10pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here