Adjust stat logging

alex_b - June 26, 2009 - 16:48
Project:FeedAPI
Version:6.x-1.x-dev
Component:Code feedapi (core module)
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

For debugging, it is sometimes very useful to monitor memory usage on cron feed processing.

I propose to monitor memory increase while processing feeds. Will post patch shortly.

#1

alex_b - June 26, 2009 - 16:49
AttachmentSize
503242-1_measure_mem.patch 1.07 KB

#2

alex_b - June 26, 2009 - 16:49
Assigned to:alex_b» Anonymous
Status:active» needs review

#3

Aron Novak - June 29, 2009 - 10:10
Status:needs review» reviewed & tested by the community

(PHP 4 >= 4.3.2, PHP 5) memory_get_usage - php.net
Required: PHP version 4.3.5 or higher - d.o

Then RTBC.

#4

alex_b - July 2, 2009 - 15:30
Status:reviewed & tested by the community» needs review

Why do we actually only store stats if there are $new items?

Pending: php version checking.

AttachmentSize
503242-4_measure_mem.patch 3.19 KB

#5

alex_b - July 2, 2009 - 15:31

Patch in #4 contained unrelated changes.

AttachmentSize
503242-5_measure_mem.patch 1.68 KB

#6

alex_b - July 2, 2009 - 15:43

Better comment wording.

AttachmentSize
503242-6_measure_mem.patch 1.68 KB

#7

Aron Novak - July 2, 2009 - 15:56

Let's explain the change of the meaning of update rate field at the admin interface.

AttachmentSize
503242_changelog_change.patch 771 bytes

#8

alex_b - July 2, 2009 - 15:57
Title:Measure memory usage» Adjust stat logging

Ok, this is growing out to be a more comprehensive overhaul of the statistics logging:

- Log not only if there are new items
- Log next refresh time
- Log growth in memory usage

AttachmentSize
503242-7_new_stats.patch 2.05 KB

#9

Aron Novak - July 6, 2009 - 10:53
Status:needs review» reviewed & tested by the community

Unified patch of #8 and #7
Seems to be okay.

AttachmentSize
503242-8_new_stats.patch 2.8 KB

#10

alex_b - July 6, 2009 - 14:23

RTBC from my point of view, too.

#11

Aron Novak - July 6, 2009 - 14:50
Status:reviewed & tested by the community» fixed

#12

System Message - July 20, 2009 - 15:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.