Updating a signup as an admin doesn't show statuses without "show in form"
capellic - June 26, 2009 - 19:10
| Project: | Signup Status |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
Noticed that when editing a signup (signup/edit/]nid]), Status only contains the values that are designated to "show on form". I can see how this would make sense from one perspective, but it doesn't make sense as an admin who wants to change a status. (Luckily I am able to change the status using VBO.)
What about using a permission to allow this field to show up?
#1
At first glance, I thought this was duplicate with #406414: not being able to adminster signup statuses, but you're talking about the interface for an admin to edit another user's signup. Yeah, in that case, we should probably include all the possible status values -- I don't think we want a new permission for this. We should know that's the version of the signup form we're altering, so it should be fairly easy to somehow figure that out inside signup_status_form_signup_edit_form_alter() and then add a second optional parameter to _signup_status_status_form_element() which would default to FALSE, but if set to TRUE, include all status codes in the form element. Feel free to roll a patch if you're up for it, though I'll be offline for the next 2 weeks so I won't be able to review or commit it until after that. However, other folks know about and care for this module, so maybe someone else can step in...