"Add new comment" link (or Reply with Advanced Forum) goes to core comment form
iva2k - June 27, 2009 - 05:42
| Project: | Node comments |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | duplicate |
Jump to:
Description
Forum topic is configured to have nodecomment type for comments.
Reply button in forum topic links to /reply/%#comment-form, and is getting to a regular Drupal-comment form, not nodecomment form. Submitting comment in that form creates Drupal-comment, as I can observe in /admin/content/comment list and in /admin/content/nodecomment-convert.
The forum topic page shows correct nodecomment form (if form is enabled in settings), and submits OK.
#1
Wrong queue... Moving.
Michelle
#2
Actually, this is pretty critical. Bumping priority. (And, yes, I did look and confirm the bug as well)
Michelle
#3
Oh ffs... I should not try to test something when I first wake up. The node type is called comment. Duh. Ignore my reply for now. Looking again, it appears I can't repro this after all. I'll look again when I've had some breakfast and wake up a bit. :)
Michelle
#4
Ok, I've played with this some more and still can't repro it. Sorry for jumping the gun. When I saw the link went to node/add/comment I saw the word "comment" there and thought it was adding a comment. It wasn't until after I hit submit that the word "node" perculated into my sleepy brain. :)
I did find something weird, though... When flipping back and forth between comment form on the same page and comment form on a different page, I somehow managed to break it so nothing displays except the top node. I'll investigate that more and file a new issue if it turns out to not be user error. But thought I'd mention it in case anyone else wants to look into it in the mean time.
Michelle
#5
Actually, in my case it was "comment form on node page" configuration. The form in the node page and forum topic page was indeed "Comment/nodecomment", which is expected. But there is still a "Reply" button in the bottom area of AF topic view. That button opens core comment form (unexpected), regardless of the "Forum topic" content type setting for comments to use "Comment" content type from nodecomment.
Note to self: the above statement contains 8 words "comment" and will confuse anyone. Trying to rephrase:
I have AF and nodecomment installed.
I have "Forum topic" type and "Comment" type in Content types.
"Forum topic" type is set up to use "Comment" type for comments, which is a nodecomment provision.
Other "forum topic" settings:
In Forum topic view (/node/%) there are "Post Reply" (top area) and "Reply" (bottom of topic) buttons.
"Post Reply" button opens path /node/%#node-form (as expected)
"Reply" button opens path /comment/%#comment-form (not expected)
The latter path (/comment/%#comment-form) shows form that posts core comment, bypassing the nodecomment setting to use node of type "Comment"
(Note: % above is node id)
Does that explain the problem better?
#6
I still can't reproduce it... And that doesn't actually make any sense. You said the "post reply" button is correct but the "reply" button isn't? Yet the "post reply" button gets its path from the "reply" one, which is provided by comment/nodecomment. So they would have to either both be right or both be wrong.
Michelle
#7
I know reproducing a bug can be hard - there are so many variables there...
I enabled anon comments on that test site. Please see for yourself how links actually turn out here:
http://qphy.org/node/7
#8
Your "comment" at the bottom of the form has the option to select what forum it should go into. That looks to me like you have set your "comment" node type to be allowed to be posted in the forum, which it shouldn't be. I don't know if that's causing the results you're getting, but undoing that would be a good first thing to try.
Michelle
#9
Thanks for the information - I followed your pointer, and removed Comment content type from Forum vocabulary. It did not change the link.
I did a complete uninstall of all modules from comment up (forum, af, nodecomment, comment upload, and a bunch of others). Then I reinstalled nodecomment & AF, letting them pull in only modules they require. Same result - reply button in forum topic points to core comment.
One more observation - reply button in comment nodes point to proper form.
I consider that this cannot be used on production site, because forum users will click on the reply button and screw the forums up, so bumping it to critical.
#10
I attacked this problem myself, and was able to locate the offending code in... acquia_marina theme. It blindly replaces whole 'comment_add' link with hard-coded href, apparently copied from comment.module. See #328055: Does not work with Nodecomment module. I'll keep this bug in nodecomment queue for others to be able to find it. That may explain why Michelle was not able to reproduce it, if she used a different theme.
#11
Oooh, yeah, they're doing quite a bit of manipulation on the links. That's going to interfere with AF a lot. Which sucks because that's one of the most popular themes. I hope we can find a way to work together. I've left a comment over there.
Michelle