E-mail notifications are broken
milesgillham - June 27, 2009 - 09:41
| Project: | Classified Ads |
| Version: | 6.x-2.0-alpha2 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Description
Hmmm, I thought this was fixed, will need to address this urgently. Example of the mailer-daemon bounce:
From: Reply-to: webmaster@<xxx>.com X-Mailer: D.rupal Return-path: webmaster@<xxx>.com Er.rors-to: webmaster@<xxx>.com
Date: Sat, June 27, 2009 4:00 pm
To: <xxx> (less)
<yyy>
classified
ads
expiring
soon!
Priority: Normal
#1
Okay, this has never worked in the 6.x branch - was set up for Drupal 5 mail handling. I've just applied the attached patch to the -dev stream for testing. You can either apply yourself to the alpha2 release or wait for the dev tarball to update.
Cheers,
Miles
#2
E-mail notifications are now being sent under 6.x (yay), however some variables weren't being replaced - that should now corrected in the -dev branch. Will just wait a day or two to make sure both types of notification are correctly processed.
This is pretty important functionality so this patch, and any other bug fixes pending, will go into an alpha3 release later in the week.
Cheers,
Miles
#3
Okay, in general !variables are not being handled correctly across the module, resulting in some weird things appearing in the query string, and not being parsed. A general cleanup of those will also fix the embedded e-mail vars.
#4
Aha, the problem is around t() - args() have managed to be separated from the t() call and end up inside l() calls around the place. Will be an easy fix.
#5
Fixed in the -dev branch.
#6
Re-opening - I've found one link is coming through with an underscore where there should be a hyphen. It's minor, but annoying when you click through and don't get to the My Classifieds tab and end up on the user page and have to click again. It would actually also be nice to click on the particular ads in the email notification directly.
#7
The link issue is fixed in -dev branch.
#8
Automatically closed -- issue fixed for 2 weeks with no activity.