Closed (won't fix)
Project:
Drupal core
Version:
7.x-dev
Component:
menu system
Priority:
Normal
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
27 Jun 2009 at 14:17 UTC
Updated:
20 Sep 2009 at 14:53 UTC
Jump to comment: Most recent file
Comments
Comment #1
clemens.tolboomPatch contains a theme.inc check for an empty 'main_menu' and add the appropriate link taken from the removed menu_add in default.profile. Switching theme still shows the link for the main menu.
Comment #2
clemens.tolboomComment #3
kika commentedComment #4
kika commentedComment #5
sutharsan commentedPatched tested and checked. Works as advertised.
Unassigning Clemens.
Comment #7
webchickDon't be a ponce, testing bot.
Comment #8
clemens.tolboomComment #9
catchLooks great but the !count() should be an !isset().
Comment #10
clemens.tolboomafaik we need count because in line 1941
is set to an empty array and
returns an array.
But I haven't tested the toggle_main_menu yet :(
Comment #11
catchSorry, missed that, but in that case empty() should be fine.
Comment #12
clemens.tolboomComment #13
clemens.tolboom- moved theme.inc code a few lines up
- included test for toggle_main_menu
- wrapped t() arround 'Add a main menu link'
Comment #15
clemens.tolboomNot sure why this test failed.
Comment #17
clemens.tolboomRebuild patch
* The menu-item "Add a main menu item" for main-menu is just a link added through theme.inc
* When adding a menu-item to the main-menu this link disappears.
* When removing _all_ menu-items from main-menu this link appears.
* This is only available when main-menu is configured to show up.
Comment #19
clemens.tolboomBojhan adviced to postpone this feature. This feature is now confusing with regard to the toolbar.
Comment #20
clemens.tolboomComment #21
clemens.tolboomAccording to #582734: Removal of Add a main menu link this could be closed. #473268: D7UX: Put edit links on everything adds links for everything :)