Improve description for teaser length

This is the actual text:

"The maximum number of characters used in the trimmed version of a post. Drupal will use this setting to determine at which offset long posts should be trimmed. The trimmed version of a post is typically used as a teaser when displaying the post on the main page, in XML feeds, etc. To disable teasers, set to 'Unlimited' . Note that this setting will only affect new or updated content and will not affect existing teasers."

Here is a patch that changes the text. Looks like showed in the screenshot now.

Also found the same text in two other places: modules/node.admin.inc and modules/aggregator/aggregator.preprocessor.inc

Since this is basically the same issue, I changed the description there as well. I hope it is O.K. not opening issues for those separately.

So first node.admin.inc here

And also for aggregator.preprocessor.inc

I like these text changes.

For ease of application, though, can we combine the three separate patches into one unified diff?

I guess so. Was a bit uncertain if this was best practice. Not so experienced in patching.
But thinking about it, much larger and touching more files patches have been committed... Will create one patch for all of this.

Rolled the patches into one.
As the description appears to be gone from node.admin.inc it is only for
aggregator.processor.inc and content_types.inc

One small thing that I just now noticed: "This setting will only affect new or updated content: existing posts keep their teaser length."

IMO, that colon should be a semi-colon. Other than that, I'd happily RTBC this as I think these are great changes.

The teaser length affects new and old content now (that's why This setting will only affect new or updated content: existing posts keep their teaser length. was removed from content_types.inc) so you shouldn't add it back.

Tried something, we shouldn't use post.

@Bojhan: sounds much better.

Slight modification: "The maximum number of characters used in the trimmed version of newly added content.".

I don't know for aggregator, but for node content the filed is actually a summary OR trimmed version. So I think this should be clear for the user and I don't know if it is right now.

@stBorchert If the teaser now affects new and old content now, we don't need to mention "newly added".

@tic2000 Can you suggest a solution? Remember that we don't have a teaser splitter anymore so this only applies to automaticly generated teasers (as far as I know)

@Bojhan I don't know. "Maybe The maximum number of characters used in the trimmed version of content. Used if a summary is not provided."?

I wonder if we really got to mention that or if we confuse the user. If a user is creating a teaser manually, he / she should expect it to be exactly the length that is entered there? Thus this would not be needed.

Who will read this description? Someone who first has to find out that you can influence teaser length at all, which might be surprising. Then I would him confuse the least possible.

If it has to be.... How about The maximum number of characters used in the trimmed version of content that is automatically created.

If the usability guys (I don't know who they are) think the text is enough then it's enough for me too. I just want to be sure it's enough.

I don't think it makes much sense to provide an "in case" text. Especially because summary might not always be there.

Bojhan so with or without the mentioning of hand-created teasers?
In a radical lust of the shorter the better #11 has my vote.

I vote for version in #11 as well.

Who wants to RTBC?
I'm not an Usability expert and I'm not a native English speaker so I can't do it.

imo, not adding a mention that this only applies to automatically generated teasers will confuse users in the long run

how about "The maximum number of characters used in the trimmed version of content for which a trimmed version was not provided."
or "The maximum number of characters used in the trimmed version of content unless a trimmed version was provided."
or even "The maximum number of characters used in the automatically generated trimmed version of content."

¢2

#11 looks fine to me too.

@seutje
Keep in mind that the text is on an administration page (content type creation/editing) and not on node creation page.

Committed to CVS HEAD. Thanks.

"trimmed version" should be "summary version" IMO. Summary is the word used by field API and thus used for the body field. Not a big deal.

In this case trimmed is the perfect word. The field is a summary or trimmed text. This text is for the configuration of the trim, we don't touch the summary if any is provided.

moshe "teaser" has vanished from UI text completely and been replaced by "trimmed version". So it is a matter of consequent use.
I've also seen teaser in some places, and as it is the word we commonly use when talking about it, there is probably no way of getting rid of it... But in Core interfaces, we must decide on one direction.

Automatically closed -- issue fixed for 2 weeks with no activity.