s5 slideshow link available for book pages that don't belong to an outline

AntoineSolutions - June 28, 2009 - 00:06
Project:S5 presentation player
Version:6.x-1.x-dev
Component:Code - s5_book
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active
Description

If you create a book page and do not associate it with a book outline, an invalid s5 slidedshow link is available for users to click on. This link should only be available for content that is associated with a book outline.

Cheers,

Antoine

#1

greggles - June 28, 2009 - 21:05

How is it "invalid." I think a single page slideshow is legitimate. If the single page slideshow doesn't work...then that's broken and we should fix that rather than "fixing" the link.

#2

AntoineSolutions - June 29, 2009 - 16:46

Greggles,

I assumed that the the intention of the module was only to have presentations for book outlines, not individual book pages. If the objective is to provide a presentation for any book page, then this is broken for book pages not belonging to an outline.

Cheers,

Antoine

#3

greggles - June 29, 2009 - 17:54

I really appreciate all the issues that you have filed for the module. An active set of users testing helps make a module great.

However:

then this is broken for book pages not belonging to an outline.

is not detailed enough. What is broken? What action do you take, what response do you expect?

#4

AntoineSolutions - July 1, 2009 - 01:26

Sorry for the poorly written issue.

When creating a book page that doesn't belong to a book outline, an "s5 slideshow" link is presented to the user, but clicking this link does not take the user to the presentation, instead it simply reloads the current page.

I hope this is a little more clear.

P.S. What software do you use to make your awesome screencasts?

Cheers,

Antoine

 
 

Drupal is a registered trademark of Dries Buytaert.