Patch to follow.

CommentFileSizeAuthor
#1 ctools.install-504286-1.patch1.01 KBdarren oh

Comments

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Active » Needs review
StatusFileSize
new ctools.install-504286-1.patch1.01 KB
merlinofchaos’s picture

merlinofchaos commented

Why?

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

For consistency: the sid_obj_name appears to serve the same purpose as a primary key. For good database design: a primary key has the additional benefit of preventing duplicate records.

merlinofchaos’s picture

merlinofchaos commented

I have never believed in having primary keys that are unused. They add additional indexing weight for very specious benefits, IMO.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

There's already an index, so it's not unused. Good design may have been a consideration in making this an index instead of a primary key, but the ctools_css_cache table uses a primary key.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

All right. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.