Jump to top of page

jimyhuang - June 28, 2009 - 08:13
Project:Text Size
Version:6.x-1.3
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Because of the href of link is "#". When click image or link, browser will bring user to top of page.

To solve this issue, I just change jquery.textsize.js, add "return false;" in click event. Not sure this method is correct, looks like solved my issue.

  if ($.cookie("textsize") && $.cookie("textsize") != textsize_maximum) {
    $('a.ts_increase[href=#]').click(
           removeBC();
           // bala bala...
 
+        return false;
      }
    );
  };

#1

brian_c - July 13, 2009 - 23:42

This is a very good idea, all click() handlers should return false to prevent browser from following the "#" link (which goes to top of page).

#2

Christian Zwahlen - September 15, 2009 - 10:36
Status:needs review» fixed

Fixed in the Development snapshots version.

#3

System Message - September 29, 2009 - 10:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.