Block configuration page doesn't show highlighted block regions for non-default themes

I can confirm this bug.

Here's a patch that adds a user_access('administer blocks') check to the part of block_page_alter that adds the dotted-line region label to each region.

It is not sufficient: any page below that one (like admin/build/block/akahn) will also display the regions. You need to match the path more generally.

Erroneous comment of mine, canceling. There's just a tiny performance issue with keeping user_access within the foreach loop. Not much, as it has static caching, but still..

Improved patch. Thanks to osinet for pointing out that the user_access check should be inside the path check, so that it doesn't get run on every single page ever, just on admin/build/block.

Also added a bit of documentation explaining the call to user_access.

I think that error is due to having an out of date checkout. Updated to HEAD and rerolled.

Just tested, and it looks good to me.

I think it would really make more sense to do this:

if ($item['path'] == 'admin/build/block' && $item['access']) {

or at least put the user_access() in the same if condition.

Confirmed that this fixes it in the same manner. Why not re-use the result of user_access that is provided to us? :)

Screenshots of the admin/build/block page to show what the problems was and how it is fixed now.

I like Dave Reid's change. Much more elegant. I think this is ready to go.

Mr.Bot?

Also, if you go to admin/build/block/list/stark or the block admin page of any other theme, the regions highlights are not displayed due to: $item['path'] == 'admin/build/block'

The patch decide whether to append region description by checking the page_callback of the menu item and the access property. It improves performance by moving the check out the foreach.

Re-rolling patch against HEAD.

Picking this up again.

I just updated to HEAD and it appears that this patch is no longer necessary. When logged-out, going to admin/structure/block gives me the access denied page, with no region highlights. Can someone verify this? Change the status back if I'm mistaken.

@akahn: The issues is still there.

Also, if you go to blocks configuration page of any other theme than the default theme, the regions highlights are not displayed.

Re-roled against head, same approach.

This is fixed in Drupal 7.0.

I am not sure I am posting this correctly. Hopefully I am. I still don't see the highlighted blocked regions in Drupal 7.7 like I do in Dupal 6. Is there something that I am doing wrong or is it still a bug. I will try to attach a screenshot of the issue.

ljmarik: have you seen and clicked the 'Demonstrate block regions' link in D7 yet?

yoroy: Yes, I figured it out. I had to turn on the "System Help" block. Somehow this block was disabled. Thank you for the response!

This is a apparently NOT fixed in Drupal 7. Very frustrating and means I simply cannot use Drupal. :(

See screenshot at http://img560.imageshack.us/img560/6058/drupalbug.png