The attached patch refactors the vocabulary add/edit and delete forms. It cleans up some cruft, makes existing code easier to read and makes the delete confirm form use a menu callback like Node does.

CommentFileSizeAuthor
#6 vocabulary_form_cleanup_09.patch12.81 KBxano
#4 vocabulary_form_cleanup_08.patch12.94 KBxano
#2 vocabulary_form_cleanup_06.patch12.69 KBxano
vocabulary_form_cleanup_05.patch12.04 KBxano

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new vocabulary_form_cleanup_06.patch12.69 KB
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Issue tags: +D7UX, +d7uxsprint
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new vocabulary_form_cleanup_08.patch12.94 KB

This patch makes the form's example help text equal to the default profile's Tags vocabulary's help text. This way we lose a string and another string gets shorter.

Status: Needs review » Needs work

The last submitted patch failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new vocabulary_form_cleanup_09.patch12.81 KB

Status: Needs review » Needs work

The last submitted patch failed testing.

amc’s picture

amc commented
Issue tags: -Cleanup, -D7UX, -d7uxsprint +Usability
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Closed (fixed)

This has been fixed in D7.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: xano » Unassigned